Date: Sun, 19 Dec 1999 03:41:46 +0800 From: Peter Wemm <peter@netplex.com.au> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: Warner Losh <imp@village.org>, Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Kernel broken (was: Re: cvs commit: src/lib/libc/gen fts.c) Message-ID: <19991218194147.EE8D31CA0@overcee.netplex.com.au> In-Reply-To: Message from Brian Fundakowski Feldman <green@FreeBSD.org> of "Sat, 18 Dec 1999 12:38:03 EST." <Pine.BSF.4.10.9912181237500.76308-100000@green.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Brian Fundakowski Feldman wrote:
> On Sat, 18 Dec 1999, Warner Losh wrote:
>
> > In message <Pine.BSF.4.10.9912180843120.74555-100000@green.dyndns.org> Bria
n Fundakowski Feldman writes:
> > : What do you object to? In my analysis of the changes, I didn't notice
> > : anything bad. The only difference I can think of objecting to would
> > : be reversion to using realloc() instead of reallocf(), but the code
> > : works the same either way.
> >
> > Using realloc instead of reallocf introduces a memory leak when the
> > system can't realloc the memory.
>
> They use realloc() and explicit freeing.
You know, I'd be a lot happier if you would concentrate on fixing where you
have broken the kernel:
uipc_mbuf.o: In function `m_mballoc_wait':
uipc_mbuf.o(.text+0x2cf): undefined reference to `m_mballoc_wakeup'
uipc_mbuf.o: In function `m_clalloc_wait':
uipc_mbuf.o(.text+0x3f7): undefined reference to `m_clalloc_wakeup'
Cheers,
-Peter
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991218194147.EE8D31CA0>