From owner-svn-src-projects@FreeBSD.ORG  Tue Oct 23 09:55:50 2012
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id DA9B7A9;
 Tue, 23 Oct 2012 09:55:50 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
 by mx1.freebsd.org (Postfix) with ESMTP id 7177D8FC16;
 Tue, 23 Oct 2012 09:55:50 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id BFC2F358C5D;
 Tue, 23 Oct 2012 11:55:49 +0200 (CEST)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id A59632848C; Tue, 23 Oct 2012 11:55:49 +0200 (CEST)
Date: Tue, 23 Oct 2012 11:55:49 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Peter Grehan <grehan@freebsd.org>
Subject: Re: svn commit: r241744 - projects/bhyve/usr.sbin/bhyve
Message-ID: <20121023095549.GA27951@stack.nl>
References: <201210191811.q9JIBIQu049356@svn.freebsd.org>
 <20121021121006.GA96141@stack.nl> <5085D433.4020101@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5085D433.4020101@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2012 09:55:51 -0000

On Mon, Oct 22, 2012 at 05:18:11PM -0600, Peter Grehan wrote:
> > Case 4 looks wrong. A 32-bit write clears the top 32 bits of the
> > register instead of preserving them.

>   Yep, you're right. How about:

>  > +	case 4:
>  > +		val = (reg & ~0xffffffffUL) | (operand & 0xffffffffUL);
>  > +		break;

I think you mean:
	val = operand & 0xffffffffUL;

Right?

-- 
Jilles Tjoelker