From owner-svn-src-stable-9@FreeBSD.ORG Wed Apr 24 22:07:59 2013 Return-Path: Delivered-To: svn-src-stable-9@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8E53C897; Wed, 24 Apr 2013 22:07:59 +0000 (UTC) (envelope-from jlh@FreeBSD.org) Received: from caravan.chchile.org (caravan.chchile.org [178.32.125.136]) by mx1.freebsd.org (Postfix) with ESMTP id 57EBD10C9; Wed, 24 Apr 2013 22:07:59 +0000 (UTC) Received: by caravan.chchile.org (Postfix, from userid 1000) id A4C9DC3AF9; Wed, 24 Apr 2013 22:07:52 +0000 (UTC) Date: Thu, 25 Apr 2013 00:07:52 +0200 From: Jeremie Le Hen To: Mikolaj Golub Subject: Re: svn commit: r249734 - stable/9/sys/kern Message-ID: <20130424220752.GA2622@caravan.chchile.org> Mail-Followup-To: Mikolaj Golub , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org References: <201304211714.r3LHEo0R075715@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201304211714.r3LHEo0R075715@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org X-BeenThere: svn-src-stable-9@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 9-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 22:07:59 -0000 Hi Mikolaj, On Sun, Apr 21, 2013 at 05:14:50PM +0000, Mikolaj Golub wrote: > Author: trociny > Date: Sun Apr 21 17:14:50 2013 > New Revision: 249734 > URL: http://svnweb.freebsd.org/changeset/base/249734 > > Log: > MFC r249238, r249239: > > r249238: > > Use 4-byte padding for core dump notes on both 32 and 64bit archs. > > Although native word padding (i.e. 8-byte on 64bit arch) looks to be > in agreement with standards, other parts of our code and other OSes > use 4-byte alignment. > > This is not expected to change alignment for currently generated core > dump notes, as the notes look to consist of structures with sizes > multiple of 8 on 64-bit archs. But there are plans to add additional > notes, where 4-byte vs 8-byte alignment makes difference. > Sorry, I'm a little late, trying to catch up on emails. I'd say this deserves a comment. Even if you commit log clearly states the reason for this change, a casual reader may think it would be preferable to have native alignment and fix it without thinking of checking the SVN metadata. -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons.