From owner-svn-src-all@FreeBSD.ORG Fri Sep 14 13:42:50 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D59D41065670; Fri, 14 Sep 2012 13:42:50 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id E0D128FC08; Fri, 14 Sep 2012 13:42:49 +0000 (UTC) Received: by lage12 with SMTP id e12so3306943lag.13 for ; Fri, 14 Sep 2012 06:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=E65mau9OGVdX2zPQH8+VHWBiE2ePuf2KmiWB+cP6CDc=; b=IAr4o7EVC8paxlKmQxZLgb0O9CwS9by5SSzAVxLkxmgA+JmaxSgrAmrrvSzfOZe7nu trlR9B4CSmBblSJlskFFoLM33f6SIDBSkogUDS7cVscpJK1fAVcwTYxhlB05XjEB8KoY mTCnL9LzNppUdvTiXAnbVBG7ITPdMOQsNK+9mlS+ugNrMyaQVNQP+6FA3qDsp/CbC3y2 H659+VJ6j+yrGMHy3u4YqgPYjB7O2UbNjAohS4bYbRP61vFiHeGvn+LM7/3YYkn7SF7F T+RrqtKUzfGI7908Xxn1ReppvMXWmvCRZueA8TQDXg53tA3vxJ2lGeFJvUddU6/A1eOK R7tA== MIME-Version: 1.0 Received: by 10.152.112.233 with SMTP id it9mr2406492lab.40.1347630168378; Fri, 14 Sep 2012 06:42:48 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.102.39 with HTTP; Fri, 14 Sep 2012 06:42:48 -0700 (PDT) In-Reply-To: <20120914133833.GC37286@deviant.kiev.zoral.com.ua> References: <201209132226.q8DMQMFC088169@svn.freebsd.org> <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> <20120914133833.GC37286@deviant.kiev.zoral.com.ua> Date: Fri, 14 Sep 2012 14:42:48 +0100 X-Google-Sender-Auth: UT8j6TfKkpqsXVY9HQuIPEo8GDU Message-ID: From: Attilio Rao To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240475 - in head/sys: dev/hwpmc kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2012 13:42:51 -0000 On Fri, Sep 14, 2012 at 2:38 PM, Konstantin Belousov wrote: > On Fri, Sep 14, 2012 at 01:03:13PM +0100, Attilio Rao wrote: >> On 9/14/12, Konstantin Belousov wrote: >> > On Thu, Sep 13, 2012 at 10:26:22PM +0000, Attilio Rao wrote: >> >> Author: attilio >> >> Date: Thu Sep 13 22:26:22 2012 >> >> New Revision: 240475 >> >> URL: http://svn.freebsd.org/changeset/base/240475 >> >> >> >> Log: >> >> Remove all the checks on curthread != NULL with the exception of some >> >> MD >> >> trap checks (eg. printtrap()). >> >> >> >> Generally this check is not needed anymore, as there is not a >> >> legitimate >> >> case where curthread != NULL, after pcpu 0 area has been properly >> >> initialized. >> > I do not disagree with the patch, but I do with this statement. >> > During the AP startup, there is indeed a window while curthread is NULL. >> > Unfortunately, trying to panic there is worse then not panic. >> >> Yes and why do you disagree then? That is what I wanted to say -- >> before pcpu->curthread is initialized you can get curthread == NULL. > > I disagree with the statement that curthread is always non-NULL after pcpu 0 > area has been initialized. Ah, I understand what you mean, the "0" part is wrong really, it is any pcpu area infact. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein