Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Nov 2019 14:46:13 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r355212 - head/sys/kern
Message-ID:  <201911291446.xATEkDmo013119@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans
Date: Fri Nov 29 14:46:13 2019
New Revision: 355212
URL: https://svnweb.freebsd.org/changeset/base/355212

Log:
  tty_rel_gone: add locking assertion
  
  We already assert the lock is held later during tty_rel_free(), but it is
  arguably good form to clarify locking expectations here as well at the
  top-level that other drivers use.

Modified:
  head/sys/kern/tty.c

Modified: head/sys/kern/tty.c
==============================================================================
--- head/sys/kern/tty.c	Fri Nov 29 14:02:32 2019	(r355211)
+++ head/sys/kern/tty.c	Fri Nov 29 14:46:13 2019	(r355212)
@@ -1180,6 +1180,7 @@ void
 tty_rel_gone(struct tty *tp)
 {
 
+	tty_lock_assert(tp, MA_OWNED);
 	MPASS(!tty_gone(tp));
 
 	/* Simulate carrier removal. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201911291446.xATEkDmo013119>