From owner-svn-ports-all@FreeBSD.ORG Thu Apr 23 03:39:43 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 7848C7FC; Thu, 23 Apr 2015 03:39:43 +0000 (UTC) Date: Thu, 23 Apr 2015 03:39:43 +0000 From: Alexey Dokuchaev To: Dmitry Marakasov Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r384239 - in head/games/gtkradiant: . files Message-ID: <20150423033943.GA25352@FreeBSD.org> References: <201504181629.t3IGT1eP029667@svn.freebsd.org> <20150422103006.GB4186@hades.panopticon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150422103006.GB4186@hades.panopticon> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2015 03:39:43 -0000 On Wed, Apr 22, 2015 at 01:30:06PM +0300, Dmitry Marakasov wrote: > * Alexey Dokuchaev (danfe@FreeBSD.org) wrote: > > New Revision: 384239 > > URL: https://svnweb.freebsd.org/changeset/ports/384239 > > > > Log: > > [...] > > - Clang insists that reference cannot be bound to dereferenced null > > pointer in well-defined C++ code (that is correct) and evaluates > > comparisons like &foo == 0 to false, which breaks GtkRadiant; "fix" > > this with a dirty hack by casting those "bad" references to a > > local volatile int variable > > gtk- and netradiant are now broken on amd64. Oops, of course, it should'be been intptr_t. I currently do not have any 64-bit hardware to do the tests, hence I've missed it. :( > While here, don't miss [PR 199562] I won't miss it, but it might take couple of days to review the patch (even though you seemingly already did most the of work, thanks!). ./danfe