From nobody Sat Jun 28 20:22:17 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bV3kN4sxmz60RHG; Sat, 28 Jun 2025 20:22:20 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bV3kN3Wm0z49mt; Sat, 28 Jun 2025 20:22:20 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751142140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7nTtj40wpF1y+/6g9bG9A1bhw57UE+B8wznrmdyqHvA=; b=JL2JjqLYrAkSrJYBTHvv/LUQH5VBbIUSyuVj8pcfnONAPe1Z9XryK4oZFAHDJ5YKY4m0qU CkmC0tNBsSIdW0YbqSuZJskQdX+j+aCaAHEpVteWGzQYiEJcv9iCmNTq8C+CNYNdJNjrTp X0bYY0K5F4kiYsK0cvK87g3RtjLv2ZwiDau1VQGGRVqKQQxh79iLDTMSISYKSU2+pYNN+E YCbt9+RQqNIFs+kBsG4pKQY3ITTxKRCd+tUYnLmWJpjpw83P+UAId8J6TmMQbgMxpLhAeM lrvF9NNthLB4iWnE1pYkVk00R177+rx3SCErZP9wRdA6M4LqR2TFmLykGf1hbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751142140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7nTtj40wpF1y+/6g9bG9A1bhw57UE+B8wznrmdyqHvA=; b=NXgBbe8MYcYUQ1+ga+fekim6f4EoCDbmaGg2g3rxUmFGcl3ixyeKDYrBjSedHW70Zh2vDt t+E16cxXsjZ7MBHwXGSzzYioisDHowhEO5oJpRQooLzInmGburfITY7DUPVHsOOth2AO5R pGbC4YdPQfyLwT0bS/2YYBdx64mbOUJ+dzcH2iLicpH9Ntq65kNPEX1uWCJ/f6IPpHbCTa Wa+iqlIpk+85vWZmZif1cNev5kMqVRsKMZW65zBbJKXkZO0rM4Qo9zpSkK7tkUDU2gIW/P O0K5iZHBu528Xj/i7XKTiLm4/zvPv/+o7S6RgCf0DRSyg1/KZjbjwzpmI8zoMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751142140; a=rsa-sha256; cv=none; b=V0TRHhglBY+EFm/mPrUQA/wigYmoRKSSXbrJsD4/mfQp9Wcs9TH4L8qUnw7S3iiiYHg/3d kJoL+uXgxH22UleokNdN4RdlNgrEJtwVS4jUiYWV7reFD/mLbTAG+e2ZolR1FjDg2hFS1/ 6eiLCj/gQFPWYxAaL6EFVxxviD4wzykTori+QalWpzeK3Z/mUXcpEI2G/MheQIEOpvGamc 3tW7l9z6JBGNyr1E0i10ARkxmO7eCYaXStcyuquhknaHOP0cVlXaAk1xn9ntT778LS4yMI r65HdxtJ7sLvERI6JeLk2FJtZKQQZhHvNmB3edKTq7hoSqw+ikO87Lbklfy8lQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bV3kM4l39z12RJ; Sat, 28 Jun 2025 20:22:19 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Sat, 28 Jun 2025 13:22:17 -0700 From: Gleb Smirnoff To: Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Damin Rido Subject: Re: git: 0726c6574f88 - main - sockstat: Add automatic column sizing and remove -w option Message-ID: References: <202506271559.55RFxWdm024724@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jun 27, 2025 at 08:35:18PM -0600, Alan Somers wrote: A> > First, there is a spurious second newline on every line. Even after the A> > header A> > line! How could that pass through minimal testing? A> > A> A> A second newline? Do you mean that the output is double-spaced? Because I A> do not see that at all. Figured out, this is not an extra newline, but a whitespace padding of the end of every line. So, every line has the same length as the longest one. So, my longest line is: root syslogd 2957 6 dgram /var/run/log <- [3646 7],[2737 4],[3595 3],[3557 13],[3173 3],[2547 8],[3042 3],[3003 8] Every other line is padded with whitespace to the same length. A> > Second, the default output now just inserts a huge whitespace "column" in A> > the A> > middle of the list, making it extermely wide. Note, that before this A> > change A> > the default output was fitting into 80 char terminal. Now it is not A> > fitting A> > and without any good reason to do so. A> A> You shouldn't be seeing any column that's pure whitespace. You might be A> looking at the "PROTO" column, which is often wide because some sockets A> show "stream (not connected)". The "(not connected)" part isn't new; A> that's always been there. Does your "whitespace column" go away if you use A> "-4" or "-6"? If so, Damin do you think we could move "(not connected)" A> into the "LOCAL ADDRESS" column? It might fit better there. Figured that out, too. The "whitespace column" is extended "LOCAL ADDRESS" due to one single socket: glebius telegram-d 3552 9 stream /tmp/fdadaa6adf6d2aa7396397755aab8248-TelegramDesktop ?? So in the new mode, sockstat formats all of the strings to fit the worst one, that's why its output is no so extremely wide. :( I definitely don't like it and prefer the old mode. I expect more unhappinness as more people would update their CURRENT to the new format. -- Gleb Smirnoff