From owner-freebsd-audit Sat Oct 19 5:53:18 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 405C237B401 for ; Sat, 19 Oct 2002 05:53:17 -0700 (PDT) Received: from straylight.ringlet.net (office.sbnd.net [217.75.140.130]) by mx1.FreeBSD.org (Postfix) with SMTP id 4A76C43E7B for ; Sat, 19 Oct 2002 05:53:14 -0700 (PDT) (envelope-from roam@ringlet.net) Received: (qmail 12337 invoked by uid 1000); 19 Oct 2002 12:52:54 -0000 Date: Sat, 19 Oct 2002 15:52:54 +0300 From: Peter Pentchev To: audit@FreeBSD.org Subject: Re: [CFR] 4.x-STABLE ftp client signedness patch Message-ID: <20021019125254.GD363@straylight.oblivion.bg> Mail-Followup-To: audit@FreeBSD.org References: <20021017181225.GH369@straylight.oblivion.bg> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8" Content-Disposition: inline In-Reply-To: <20021017181225.GH369@straylight.oblivion.bg> User-Agent: Mutt/1.5.1i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --z6Eq5LdranGa6ru8 Content-Type: text/plain; charset=windows-1251 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 17, 2002 at 09:12:25PM +0300, Peter Pentchev wrote: > Hi, >=20 > The "old" FTP client in -STABLE has a little problem when retrieving > files via HTTP: a variable that holds the read() return value is > unsigned, which leads to misinterpreted failures when the connection is > closed by the remote side and read() returns -1. >=20 > Yes, I know it has never really been ftp(1)'s job to fetch via HTTP; > still, this is what a friend of mine has been using until today, when he > reported the failure and I tracked down the bug. I taught him about > fetch(1), but there is no reason for the bug to stay unfixed :) >=20 > The trivial patch is attached; it only applies to -STABLE, because > -CURRENT uses lukemftp now. I took a look through the lukemftp source > with a quick grep for 'size_t' and 'unsigned', and there do not seem to > be any similar problems there. Just for the record, I just committed this to -STABLE. G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 Thit sentence is not self-referential because "thit" is not a word. --z6Eq5LdranGa6ru8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE9sVWm7Ri2jRYZRVMRAiAuAJ9ln8G7xTvbwO0fKsOoxEPRAlRe1QCgqfaX Ha/GV5IBMhtaXfZqhZMm6iQ= =s+th -----END PGP SIGNATURE----- --z6Eq5LdranGa6ru8-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message