From owner-svn-src-head@FreeBSD.ORG Tue Aug 18 18:39:04 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 72D83106564A; Tue, 18 Aug 2009 18:39:04 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id A1B958FC61; Tue, 18 Aug 2009 18:39:03 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id ADCB445CAC; Tue, 18 Aug 2009 20:39:01 +0200 (CEST) Received: from localhost (chello087206049004.chello.pl [87.206.49.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 52B8A45B36; Tue, 18 Aug 2009 20:38:56 +0200 (CEST) Date: Tue, 18 Aug 2009 20:38:58 +0200 From: Pawel Jakub Dawidek To: Attilio Rao Message-ID: <20090818183858.GB1794@garage.freebsd.pl> References: <200908181355.n7IDtmqT019165@svn.freebsd.org> <4A8AC814.2070804@errno.com> <3bbf2fe10908181106u159934b9ofc4c2a5e4793b692@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LyciRD1jyfeSSjG0" Content-Disposition: inline In-Reply-To: <3bbf2fe10908181106u159934b9ofc4c2a5e4793b692@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, Sam Leffler , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196358 - in head: share/man/man9 sys/kern sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2009 18:39:04 -0000 --LyciRD1jyfeSSjG0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 18, 2009 at 08:06:17PM +0200, Attilio Rao wrote: > 2009/8/18 Sam Leffler : > > Pawel Jakub Dawidek wrote: > >> > >> Author: pjd > >> Date: Tue Aug 18 13:55:48 2009 > >> New Revision: 196358 > >> URL: http://svn.freebsd.org/changeset/base/196358 > >> > >> Log: > >> Remove unused taskqueue_find() function. > >> Reviewed by: dfr > >> Approved by: re (kib) > > > > I don't understand why this should be removed (let alone during a code > > freeze). I can think of several uses for this function including a ddb= cmd > > that takes a taskq name and dumps it's contents. The overhead of > > maintaining the global list appears minimal. >=20 > FWIW, I agree with Sam. The only use I could think of was exactly what Sam suggested - a DDB command and that was the only possible use I found. I decided to propose removal of this KPI, because nobody decided to use it for more than 9 years now and this is a good thing to remove unused code, no? I won't fight for keeping it removed, really. If after 9 years someone will find it useful I'm all for bringing it back. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --LyciRD1jyfeSSjG0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKivVCForvXbEpPzQRAoqJAJ4u8fVeJVh08zqneE0sYBzhgpl9AQCfcMQe QhRMxxmXyuFpva5xdJsNs98= =xyEE -----END PGP SIGNATURE----- --LyciRD1jyfeSSjG0--