From nobody Fri Nov 1 20:08:21 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XgBkY4L68z5cNt4 for ; Fri, 01 Nov 2024 20:08:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XgBkY1nDYz4TV9 for ; Fri, 1 Nov 2024 20:08:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730491701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YLslyEc66zQTdivtnho4zImWzQk+J555E5qHdqFOGVU=; b=aj8JR44Z6+5wNTQTZttMQhGqBPmR9W7Bz5WNzPz+L8mkbv5iGdGmQXjWn+YXrbTCPQ0FFP hmRmFK+jhrjQdJXpTgoIuE+T8yUiWQpqL5UD9++ixN688PoNRsI/a2iZWYuwzw8EvuAhOL epFln76JJFwKdE1GZCeT3wmV+vDLcAkPfZCcFwAAIUTa/cdjHsoJoZEpDCtIE0to887FG5 9TU+39KiC9iwMEoj9NIhPtmF8uEqFcuEKbj8/EXitFspxEcmxUAFyItsn6p+r+ilC8PYPU N9qatE1Q/1YVs2yie2tQ+N1FBiLCvtP8/miuLALEzejM0ASmSChOblN/kSyKhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730491701; a=rsa-sha256; cv=none; b=Fe0n64E/F255/aN9EDlz9ttuxNcYb9o+jTvdeIlpWqtPQzwk/t8PeLoNRNkjSelpdckSRZ sUMu+Fi2xOQFQnELw3wboqivFbUZUM0VKJO3N8Y2r5/2/ot8bhmwzUPdMVyQgT5YlegkTU pA5mUkxOvarn2zqQzzAVy0awfywl1xcLGqWTEA/bm9Ny9hngZj+Ntgbvk4TKwZ3WNM9XzL GwTB3VYa/H69RE+cyFAA9uIOvj9isTH8bWWKkaanhZIFX1L+pNaW9lgq0DfcUPVzrCpqva TI0NrKRr+n5tkWoj9ESU5J9lmI17Wxr4KIQ0MLTP1oPAVthi4/sM8hFzS5fufQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XgBkY1P4RzZk8 for ; Fri, 1 Nov 2024 20:08:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4A1K8Lhk090235 for ; Fri, 1 Nov 2024 20:08:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4A1K8LL7090234 for bugs@FreeBSD.org; Fri, 1 Nov 2024 20:08:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 282478] [ipfilter] Silence a lock upon service stop Date: Fri, 01 Nov 2024 20:08:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jlduran@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282478 Bug ID: 282478 Summary: [ipfilter] Silence a lock upon service stop Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: jlduran@FreeBSD.org CC: cy@FreeBSD.org When testing review D47392, I found the following: # service ipfilter stop calling _callout_stop_safe with the following non-sleepable locks held: shared rw ipf filter load/unload mutex (ipf filter load/unload mutex) r= =3D 0 (0xffff0000417c7530) locked @ /usr/src/sys/netpfil/ipfilter/netinet/fil.c:7= 926 stack backtrace: #0 0xffff00000052d394 at witness_debugger+0x60 #1 0xffff00000052e620 at witness_warn+0x404 #2 0xffff0000004d4ffc at _callout_stop_safe+0x8c #3 0xffff0000f7236674 at ipfdetach+0x3c #4 0xffff0000f723fa4c at ipf_ipf_ioctl+0x788 #5 0xffff0000f72367e0 at ipfioctl+0x144 #6 0xffff00000034abd8 at devfs_ioctl+0x100 #7 0xffff0000005c66a0 at vn_ioctl+0xbc #8 0xffff00000034b2cc at devfs_ioctl_f+0x24 #9 0xffff0000005331ec at kern_ioctl+0x2e0 #10 0xffff000000532eb4 at sys_ioctl+0x140 #11 0xffff000000880480 at do_el0_sync+0x604 #12 0xffff0000008579ac at handle_el0_sync+0x4c I realized that WRITE_ENTER/RWLOCK_EXIT is not needed for ipfdetach(). Not = sure if it should be removed from fil.c and/or used only for ipfattach() in ip_fil_freebsd.c. # uname -mnr freebsd-15-0 15.0-CURRENT arm64 --=20 You are receiving this mail because: You are the assignee for the bug.=