From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 26 17:10:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2C7CB18B for ; Fri, 26 Apr 2013 17:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 132DF1369 for ; Fri, 26 Apr 2013 17:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3QHA08L034783 for ; Fri, 26 Apr 2013 17:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3QHA0a8034782; Fri, 26 Apr 2013 17:10:00 GMT (envelope-from gnats) Resent-Date: Fri, 26 Apr 2013 17:10:00 GMT Resent-Message-Id: <201304261710.r3QHA0a8034782@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rainer Hurling Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 33E41A87 for ; Fri, 26 Apr 2013 17:00:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 0B37112DC for ; Fri, 26 Apr 2013 17:00:03 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r3QH02Ck062228 for ; Fri, 26 Apr 2013 17:00:02 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r3QH02eI062227; Fri, 26 Apr 2013 17:00:02 GMT (envelope-from nobody) Message-Id: <201304261700.r3QH02eI062227@red.freebsd.org> Date: Fri, 26 Apr 2013 17:00:02 GMT From: Rainer Hurling To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/178185: [maintainer][patch] math/ggobi: build problem with graphviz solved X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2013 17:10:01 -0000 >Number: 178185 >Category: ports >Synopsis: [maintainer][patch] math/ggobi: build problem with graphviz solved >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 26 17:10:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Rainer Hurling >Release: 10.0-CURRENT (amd64) >Organization: >Environment: FreeBSD xxx.xxx.xxx 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r249715M: Sun Apr 21 11:16:54 CEST 2013 xxx@xxx.xxx.xxx:/usr/obj/usr/src/sys/XXX amd64 >Description: With graphics/graphviz installed, math/ggobi finds this external installation by its configure script in plugins/GraphLayout. Then it tries to use it instead of its internal graphviz version and fails when trying to build the port. This has been a longstanding problem with ggobi, not detected by tinderbox etc. As a workaround, one had to deinstall graphics/graphviz before building math/ggobi and reinstall it afterwards. That should be solved now. While here, trimming Makefiles header. >How-To-Repeat: Try to build math/ggobi, when graphics/graphviz is installed. >Fix: Greg Larkin was so kind to help me with this problem. He looked into it and gave me the hint to post-configure patch the two files. Many thanks to Greg! Patch attached with submission follows: diff -Naur ggobi.orig/Makefile ggobi/Makefile --- ggobi.orig/Makefile 2012-08-03 14:33:50.000000000 +0200 +++ ggobi/Makefile 2013-04-26 18:49:15.000000000 +0200 @@ -1,9 +1,5 @@ -# Ports collection makefile for: ggobi -# Date created: 31 January 2010 -# Whom: rhurlin -# -# $FreeBSD: head/math/ggobi/Makefile 300896 2012-07-14 13:54:48Z beat $ -# +# Created by: Rainer Hurling +# $FreeBSD$ PORTNAME= ggobi PORTVERSION= 2.1.9 @@ -33,6 +29,15 @@ ${WRKSRC}/src/ggobi-renderer-factory.c \ ${WRKSRC}/src/ggobi-renderer.c +post-configure: +# build gets irritated by the presence of an external graphviz version + @${REINPLACE_CMD} -e 's|#define HAVE_LIBGVC 1|/* #define HAVE_LIBGVC 1 */|' \ + ${WRKSRC}/plugins/GraphLayout/config.h + @${REINPLACE_CMD} -e 's|LIBGVC_CFLAGS = -I${LOCALBASE}/include/graphviz|LIBGVC_CFLAGS =|' \ + ${WRKSRC}/plugins/GraphLayout/Makefile + @${REINPLACE_CMD} -e 's|LIBGVC_LIBS = -L${LOCALBASE}/lib/graphviz -lgvc -lgraph -lcdt|LIBGVC_LIBS =|' \ + ${WRKSRC}/plugins/GraphLayout/Makefile + post-install: ${MKDIR} ${PREFIX}/etc/xdg/ggobi ${INSTALL_DATA} ${WRKSRC}/ggobirc ${PREFIX}/etc/xdg/ggobi/ggobirc.sample >Release-Note: >Audit-Trail: >Unformatted: