From owner-freebsd-bugs@freebsd.org Sun Dec 18 10:00:28 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8896BC85E09 for ; Sun, 18 Dec 2016 10:00:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 776ED8FC for ; Sun, 18 Dec 2016 10:00:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uBIA0Svl060123 for ; Sun, 18 Dec 2016 10:00:28 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 215373] Unneeded (?) assertion in ttyinq_line_iterate() from sys/kern/tty_inq.c Date: Sun, 18 Dec 2016 10:00:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jan.kokemueller@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2016 10:00:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215373 Bug ID: 215373 Summary: Unneeded (?) assertion in ttyinq_line_iterate() from sys/kern/tty_inq.c Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: jan.kokemueller@gmail.com On CURRENT r309302 with debuggin on I'm getting assertions like here: https://lists.freebsd.org/pipermail/freebsd-current/2011-May/024573.html They seem to happen randomly on key presses. Is the second "MPASS(tib !=3D NULL);" needed? Is it possible that "tib->tib= _next" is NULL on the last loop iteration (i.e. offset gets incremented to ti->ti_end)? The first MPASS should be enough. --=20 You are receiving this mail because: You are the assignee for the bug.=