Date: Fri, 5 Nov 2004 11:14:50 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Ceri Davies <ceri@submonkey.net>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c Message-ID: <20041105191450.GB44972@dragon.nuxi.com> In-Reply-To: <20041104111025.GG57641@submonkey.net> References: <200411040128.iA41ShNQ055582@repoman.freebsd.org> <20041104111025.GG57641@submonkey.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 04, 2004 at 11:10:25AM +0000, Ceri Davies wrote:
> This line now gets written to /tmp/exports:
> > | @@ -876,7 +876,7 @@ configNFSServer(dialogMenuItem *self)
> > | vsystem("echo '#/a -maproot=0 -network 10.0.1.0 -mask 255.255.248.0' >> /etc/exports");
> > | vsystem("echo '#' >> /etc/exports");
> > | vsystem("echo '# You should replace these lines with your actual exported filesystems.' >> /etc/exports");
> > | - vsystem("echo '# Note that BSD\'s export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports");
> > | + vsystem("echo \"# Note that BSD's export syntax is 'host-centric' vs. Sun's 'FS-centric' one.\" >> /tmp/exports");
>
> Also, wouldn't it just be easier to open() /etc/exports and write to it
> that way? I understand that this isn't how this is done anywhere else
> in sysinstall, but why not?
That's a good question. I guess JKH had a reason at the time. Given the
prickliness of sysinstall, I wouldn't change it without a good amount of
thought and testing.
--
-- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041105191450.GB44972>