From nobody Mon Feb 3 17:28:52 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ymtl840S2z5mBjj; Mon, 03 Feb 2025 17:28:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ymtl83WNjz3Jrp; Mon, 03 Feb 2025 17:28:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738603732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gvOP2i79p4LxCMzFyXdVXQW8bx7tZlkSyN4adepoolE=; b=MczpcuP/NuOfEEhDylwsBUkK9kGo3CwlrUPiVlEuJeUAz8zn67ErEE0QHV2sxxhWSqf1Ri IOc+yw8f/F68O8Dyss+8GLkF/jjb0dvYqCsF9uKhWjOW7YaCmoPEHdL6zi+Aog94xtzhrR ms8bdvVWf71GSGB3/177cdnrC0QELslnT4qlwMrxRsVzp9CfdSg5BB80iKO/4KKQUNo+Ol hFR1cP6iufbXUW0q/VDCksFrUBeAkp9f3rrOlTOV5iz43/u2Kn0aZaY8ybOZM4yTtVpa5/ Spw0FfGW60dCKunCyTlGS5Bvm3yE687tsMraJUqQXg44lBL0n2kYTeR7/GccpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738603732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gvOP2i79p4LxCMzFyXdVXQW8bx7tZlkSyN4adepoolE=; b=sqalJCPlEdtKEzOA+aF4YzcFt9AyEmP6AjJ8dRTFn7hFfC7F6yVpdn7pMKoKUyHYsTRGXh cgKCUQoPOQw8LtOnED2LuEnxw5keVtl6DeXw2qMZ4uYMra6kiqwRuyUqgceNMrXJnEgBMu 0w3TFxC82wI5zgoUeMAwSktl19pFBAHiFD8U0a55O5v5IX42GSH7natdOgXqKLFZICXJ1A g6PSB4OWXt0aUgNiwmosNkyzbtTxZbRy1UOUEX9hHdbT0NxPfgJ6VXBmiMq03UpMqLppP/ yXD6G1VbiPGL3zH8BUnEkQ/tnZAegnnOtWKb2aaCzty+guU5Qpmo4BGL54LtkA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738603732; a=rsa-sha256; cv=none; b=sjpikcKh+07kPILWX+E/ubKPse1OviOe8yLUMCkpn3Q9comIMckONd7wYWN0JLDC83OTTg lMmeB+uWYzUYImlcOeJdjBJHgGerO8q10s67cT5veIJ9NYoDbD7+HL+CO9iDwRVy+C+q7z b0y5+nH8gWQiVhBfpw+l6Tlg/NZB+hft8rM7nimuZJgEnhBakrLBvLdTOy7nX7UDcmkcCe d7qd9HYmS8PREsxFxa3Ch+G3BJ+epBGoupMyjFCkQ5VSBEmRKBzrCQF8Z0JbpQ0Fxxdnq8 MndPr1WY/LIdKqXxwHtHaOJvD1+JeD9oA/BbsfVl8Y3dp4cq70K73mfqsYak0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ymtl835tMzmKR; Mon, 03 Feb 2025 17:28:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 513HSqq4009291; Mon, 3 Feb 2025 17:28:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 513HSqpx009288; Mon, 3 Feb 2025 17:28:52 GMT (envelope-from git) Date: Mon, 3 Feb 2025 17:28:52 GMT Message-Id: <202502031728.513HSqpx009288@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: fdaf7d0fe10c - main - umass: Print quirks with %b List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fdaf7d0fe10c1b0017305627f28e6e59149aadaa Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=fdaf7d0fe10c1b0017305627f28e6e59149aadaa commit fdaf7d0fe10c1b0017305627f28e6e59149aadaa Author: Warner Losh AuthorDate: 2025-02-03 17:25:27 +0000 Commit: Warner Losh CommitDate: 2025-02-03 17:25:27 +0000 umass: Print quirks with %b Print the quirks in a more human-readable form. When testing a dozen different removeable devices, the hex numbers quickly blur... Sponsored by: Netflix --- sys/dev/usb/storage/umass.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/sys/dev/usb/storage/umass.c b/sys/dev/usb/storage/umass.c index ba10a23d2987..9137f3eb895e 100644 --- a/sys/dev/usb/storage/umass.c +++ b/sys/dev/usb/storage/umass.c @@ -365,6 +365,26 @@ typedef uint8_t (umass_transform_t)(struct umass_softc *sc, uint8_t *cmd_ptr, /* Device does not support 'PREVENT/ALLOW MEDIUM REMOVAL'. */ #define NO_PREVENT_ALLOW 0x8000 +#define UMASS_QUIRKS_STRING \ + "\020" \ + "\001NO_TEST_UNIT_READY" \ + "\002RS_NO_CLEAR_UA" \ + "\003NO_START_STOP" \ + "\004FORCE_SHORT_INQUIRY" \ + "\005SHUTTLE_INIT" \ + "\006ALT_IFACE_1" \ + "\007FLOPPY_SPEED" \ + "\010IGNORE_RESIDUE" \ + "\011NO_GETMAXLUN" \ + "\012WRONG_CSWSIG" \ + "\013NO_INQUIRY" \ + "\014NO_INQUIRY_EVPD" \ + "\015RBC_PAD_TO_12" \ + "\016READ_CAPACITY_OFFBY1" \ + "\017NO_SYNCHRONIZE_CACHE" \ + "\020NO_PREVENT_ALLOW" \ + + struct umass_softc { struct scsi_sense cam_scsi_sense; struct scsi_test_unit_ready cam_scsi_test_unit_ready; @@ -956,7 +976,7 @@ umass_attach(device_t dev) sc->sc_proto & UMASS_PROTO_WIRE); } - printf("; quirks = 0x%04x\n", sc->sc_quirks); + printf("; quirks = 0x%b\n", sc->sc_quirks, UMASS_QUIRKS_STRING); #endif if (sc->sc_quirks & ALT_IFACE_1) {