From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 11 09:06:17 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9541A37B404; Sun, 11 May 2003 09:06:17 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 460E843FD7; Sun, 11 May 2003 09:06:16 -0700 (PDT) (envelope-from petef@FreeBSD.org) Received: from freefall.freebsd.org (petef@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h4BG6GUp066016; Sun, 11 May 2003 09:06:16 -0700 (PDT) (envelope-from petef@freefall.freebsd.org) Received: (from petef@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h4BG6FN9066012; Sun, 11 May 2003 11:06:15 -0500 (CDT) Date: Sun, 11 May 2003 11:06:15 -0500 (CDT) From: Pete Fritchman Message-Id: <200305111606.h4BG6FN9066012@freefall.freebsd.org> To: dowen@nexusxi.com, petef@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/40396: New port: Logging daemon for Linksys BEFSR11/41/81 Routers X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 May 2003 16:06:18 -0000 Synopsis: New port: Logging daemon for Linksys BEFSR11/41/81 Routers State-Changed-From-To: open->feedback State-Changed-By: petef State-Changed-When: Sun May 11 11:04:26 CDT 2003 State-Changed-Why: Couple things to fix before importing this, and it looks like since you wrote this, you can just fix them in the dist and release 1.1 :-) . don't add -O2 to CFLAGS . don't hardcode /usr/local; respect ${PREFIX} . don't install a periodic script to /etc/periodic; ports should not touch anything outside of ${PREFIX}. I'd recommend installing it into ${EXAMPLESDIR} and including a pkg-message alerting users they can copy the script over to their periodic dir. http://www.freebsd.org/cgi/query-pr.cgi?pr=40396