From nobody Fri Dec 29 11:29:34 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1jpM4mH8z55vHP for ; Fri, 29 Dec 2023 11:29:47 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1jpL6fQXz3LYH; Fri, 29 Dec 2023 11:29:46 +0000 (UTC) (envelope-from tuexen@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:d8cb:c5d8:57fa:1e9b]) (Authenticated sender: micmac) by drew.franken.de (Postfix) with ESMTPSA id 017E6721E280D; Fri, 29 Dec 2023 12:29:35 +0100 (CET) Content-Type: text/plain; charset=us-ascii List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: devel/nspr: Fails to build on 1500008 5f71f9636efa From: tuexen@freebsd.org In-Reply-To: Date: Fri, 29 Dec 2023 12:29:34 +0100 Cc: FreeBSD CURRENT Content-Transfer-Encoding: quoted-printable Message-Id: <9EE91B0D-6CFB-464E-AB9C-3A15D77D55FB@freebsd.org> References: To: Nuno Teixeira X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:680, ipnet:2001:638::/32, country:DE] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4T1jpL6fQXz3LYH > On Dec 29, 2023, at 10:18, Nuno Teixeira wrote: >=20 > Hello all, >=20 > =46rom 1500007 to 1500008 devel/nspr (dependency of firefox) fails: >=20 > ### > cc -o prmapopt.o -c -fvisibility=3Dhidden -O2 -pipe = -fstack-protector-strong -fno-strict-aliasing -ansi -Wall -fPIC = -UDEBUG -DPACKAGE_NAME=3D\"\" -DPACKAGE_TARNAME=3D\"\" = -DPACKAGE_VERSION=3D\"\" -DPACKAGE_STRING=3D\"\" = -DPACKAGE_BUGREPORT=3D\"\" -DPACKAGE_URL=3D\"\" -DNDEBUG=3D1 = -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=3D1 -DHAVE_VISIBILITY_PRAGMA=3D1 = -DXP_UNIX=3D1 -DFREEBSD=3D1 -DHAVE_BSD_FLOCK=3D1 -DHAVE_SOCKLEN_T=3D1 = -DHAVE_POINTER_LOCALTIME_R=3D1 -DHAVE_DLADDR=3D1 -DHAVE_LCHOWN=3D1 = -DHAVE_SETPRIORITY=3D1 -DHAVE_STRERROR=3D1 -DHAVE_SYSCALL=3D1 = -DHAVE_SECURE_GETENV=3D1 -D_REENTRANT=3D1 -D_THREAD_SAFE=3D1 = -DFORCE_PR_LOG -D_PR_PTHREADS -UHAVE_CVAR_BUILT_ON_SEM -D_NSPR_BUILD_ = -I../../../dist/include/nspr -I./../../pr/include = -I../../../pr/include/private prmapopt.c > In file included from prmapopt.c:46: > /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' > 82 | static inline uint16_t > | ^ > /usr/include/netinet/tcp.h:82:23: error: expected ';' after top level = declarator > 82 | static inline uint16_t > | ^ > /usr/include/netinet/tcp.h:88:8: error: unknown type name 'inline' > 88 | static inline void > | ^ > 3 errors generated. > ### >=20 > Any clues? You are compiling with -ansi, which means C89. C89 does not support = inline. I think support for inline was added in C99. I think we have two options: 1. Build the ports with a C version of at least C99. 2. Remove the inline from tcp_[gs]et_flags(). Best regards Michael > --=20 > Nuno Teixeira > FreeBSD Committer (ports)