From owner-freebsd-current@FreeBSD.ORG  Thu Dec 11 14:39:26 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D8E2916A4CF
	for <freebsd-current@FreeBSD.org>;
	Thu, 11 Dec 2003 14:39:26 -0800 (PST)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9726643DD1
	for <freebsd-current@FreeBSD.org>;
	Thu, 11 Dec 2003 14:12:14 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.9p2/8.12.9) with ESMTP id hBBMC6eF056403;
	Thu, 11 Dec 2003 14:12:11 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200312112212.hBBMC6eF056403@gw.catspoiler.org>
Date: Thu, 11 Dec 2003 14:12:06 -0800 (PST)
From: Don Lewis <truckman@FreeBSD.org>
To: jesse@wingnet.net
In-Reply-To: <bra7n5$c1l$1@sea.gmane.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
cc: freebsd-current@FreeBSD.org
Subject: Re: LOR: ffs_snapshot.c from 5.2-BETA
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Dec 2003 22:39:27 -0000

On 11 Dec, Jesse Guardiani wrote:
> Don Lewis wrote:
> 
>> On  9 Dec, Jesse Guardiani wrote:
>>> Howdy list,
>>> 
>>> Has anyone seen this yet? Happened while I was fsck'ing my
>>> external USB hard drive a few days ago. Didn't see anything
>>> recent like this in the archive (Nov was the closest, but it
>>> looked like a separate issue).
>>> 
>>> 
>>> acquiring duplicate lock of same type: "vnode interlock"
>>>  1st vnode interlock @ ufs/ffs/ffs_snapshot.c:488
>>>  2nd vnode interlock @ ufs/ffs/ffs_snapshot.c:491
>>> Stack backtrace:
>>> backtrace(c06df4ef,c06e3b95,c06eca1f,1eb,246) at backtrace+0x17
>>> witness_lock(c42b9a28,8,c06eca1f,1eb,c3b48678) at witness_lock+0x672
>>> _mtx_lock_flags(c42b9a28,0,c06eca16,1eb,c19dbf00) at _mtx_lock_flags+0xba
>>> ffs_snapshot(c3abbc00,bfbfed88,70,c05482f3,c073f800) at
>>> ffs_snapshot+0x1759
>> 
>> A related LOR was reported a few days ago.  I think it is harmless, but
>> I also think I know how to fix it.
> 
> Going once... Going twice...

It's more complicated that I thought at first.  I hoping to have some
time to work on it over the holidays.