From owner-svn-src-head@freebsd.org Thu Oct 17 21:16:30 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B43BC15DD65 for ; Thu, 17 Oct 2019 21:16:30 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46vMRL2B9Qz3Fhq for ; Thu, 17 Oct 2019 21:16:30 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1571346988; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=Ct6cRaEhpgETibrLCJ0lhS4T9vSLG9e3TKK72rmki49kFVffD+p7aE87hipf/xb5N59DRtKmu8RWK e1qI6iSorDilu2N5qhyD0iC3PJJIaWxujj+//rD15UpJ+FjA8uEp5k2BkCdcPyJx4d2FPmc66A0630 tKHyggLxIWkI5i2BdBRm6tvR+L/MuWnI5u54WDXjeQhyaXdT51XnGYA7PMV6cHOs/LKjOegpcJAqXo TCpYK7rkJenXXYwh5Iw3KfZOIrM1WoPzJzzCOYr4njQZabSdgPpK14jpXfql7iWxXtQLa+qZ8Tcop8 lYwHanT5m03We1SVqU67ZVNp1QuQl4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=l+Rm6a2oiw2zQaqnJ++OpOiAmylKMotlKmrGgdofYlc=; b=Z3DZG8D9kjFbcDqtlS3Bm4g73l0oKhJlW/avyXDRCzj2yN5e0mobdKaKujxCqEWKDLMo9FVyqvoaj SLutvlsGG1lKKu1ikCMSls8Dzjsl9K5Hy3H55ljpA+RQ23Du3R96WmxziA2H+Kt1170uOXUkMfRc1O dNmuyTv4l29d9bKTyYCw8SvnfgTNVbsz9BDIjDkQuTLdHTnl8d/ldh7+kzwjnHlJfDyfURxQW4iShm TXu8XY3dtAPE9ridnAnuoZ3QHPr6fKLfZDhbVWQqpFGgnKmUmaASq9pm7jYEA2LLfqEaiALBdXsCYm xEm+R29HIChqZqv5JQ98D+ArzW6ATww== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=l+Rm6a2oiw2zQaqnJ++OpOiAmylKMotlKmrGgdofYlc=; b=vL9SkXlHGZUVMlaVqE/Qe4vkvJeglKEiDvt0lZCLYCOkCWLfITSURKTPfjDP6/lNTfgK8YrGDnZ9t 8si5aeFvj3cQJNEaSgbw0uQhnQytt9u+iDmvYLuxR69msJ1A9AnvwZ8ebdjZA4wLF9vIX3EaBYeLFz 29IrKr8cFT5w9yFY09geJZ8mUozSDq2n0mNiI5YCO/Iz2qfqc3nNeOdxrKWIN2ZyrXTLqxqHCIXgcV CkXTEpQgToU8OEKAb/iSWBj/t7WGJ60tqVKY8AppQJ+1aKmDhhz9cdwOOXrP7Y49ofLfPnTp0nwArO FevRxjEvAAeymJHXosASCTq3r0JrRIA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 613586fe-f123-11e9-85ed-13b9aae3a1d2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 613586fe-f123-11e9-85ed-13b9aae3a1d2; Thu, 17 Oct 2019 21:16:27 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x9HLGQ0g018735; Thu, 17 Oct 2019 15:16:26 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <179d7a5e30169f4b51fe0123a173571605fb8f28.camel@freebsd.org> Subject: Re: svn commit: r352909 - in head: contrib/elftoolchain/nm usr.bin/nm From: Ian Lepore To: Alan Somers Cc: Mark Johnston , src-committers , svn-src-all , svn-src-head Date: Thu, 17 Oct 2019 15:16:26 -0600 In-Reply-To: References: <201909301728.x8UHS0QF070658@repo.freebsd.org> <20191017174801.GA6447@raichu> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46vMRL2B9Qz3Fhq X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.76 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.76)[-0.758,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Oct 2019 21:16:30 -0000 On Thu, 2019-10-17 at 13:05 -0600, Alan Somers wrote: > On Thu, Oct 17, 2019 at 12:48 PM Ian Lepore wrote: > > > On Thu, 2019-10-17 at 12:17 -0600, Alan Somers wrote: > > > There might be something wrong with my environment: > > > /usr/include/libcasper.h is absent. But still, shouldn't the > > > build > > > be > > > using the version from the source tree, instead of from the > > > environment? > > > -Alan > > > > > > > There should be copies of libcasper.h in your objdir: > > > > obj/arm.armv7/tmp/legacy/usr/include/libcasper.h > > obj/arm.armv7/tmp/usr/include/libcasper.h > > > > -- Ian > > > Uh, I found the problem. I had WITHOUT_CASPER=1 in > /etc/src.conf. So the > problem is that nm can't build without casper. Perhaps the #include > should > be guarded, as it is in usr.bin/kdump/kdump.c. But plenty of other > programs, like usr.bin/tail and usr.bin/wc, don't have such > guards. And > looking at lib/libcasper/libcasper/Makefile, it seems as though > libcasper.h > should be installed regardless. So I still need to figure out why it > wasn't installed on my system. > > -Alan It's probably because Makefile.inc1 contains: .if ${MK_CASPER} != "no" _lib_casper= lib/libcasper .endif so WITHOUT_CASPER means that the libcasper dir isn't even visited when prebuilding libs. But you need to visit that dir so that it can install the header file (but not the lib, because MK_CASPER will be "no"). I think lib/libcasper just needs to be unconditionally listed as one of the prebuild libs in Makefile.inc1. -- Ian