From owner-cvs-all  Sun May 23  6:11:51 1999
Delivered-To: cvs-all@freebsd.org
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3035515304; Sun, 23 May 1999 06:11:45 -0700 (PDT)
	(envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id XAA24127;
	Sun, 23 May 1999 23:11:44 +1000
Date: Sun, 23 May 1999 23:11:44 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199905231311.XAA24127@godzilla.zeta.org.au>
To: jb@FreeBSD.org, phk@critter.freebsd.dk
Subject: Re: cvs commit: src/sys/kern vfs_conf.c
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>>  Modified files:
>>    sys/kern             vfs_conf.c 
>>  Log:
>>  Make MFS_ROOT work again. MFS_ROOT means that rootdev is not set.
>>  
>>  Broken by: phk
>>  Problem ignored by: phk
>
>The problem is not ignored, I've been on the road all last week.
>
>This change is wrong: MFS should not be magic in the generic code.
>
>Please back this out.
>
>I think this should be fixed by setting the rootdev to the (pseudo)
>devsw entry for MFS which should be created correctly (see the
>patch I sent out for test earlier today).

No, setting rootdev is bogus; rootdev is not used for mfs.  `rootdev !=
NODEV' is just used as a flag in vfs_conf.c when it probably shouldn't be.
I may have broken this when I added rootdevnames[].  Things used to work
for mfs because rootdev was set to a garbage value that happened to be
!= NODEV.  I currently use the garbage value 0 (set it in autoconf.c).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message