From owner-freebsd-net@FreeBSD.ORG Fri Sep 21 08:09:09 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 21EDE106564A; Fri, 21 Sep 2012 08:09:09 +0000 (UTC) (envelope-from anshukla@juniper.net) Received: from exprod7og110.obsmtp.com (exprod7og110.obsmtp.com [64.18.2.173]) by mx1.freebsd.org (Postfix) with ESMTP id 7E7598FC0C; Fri, 21 Sep 2012 08:09:08 +0000 (UTC) Received: from P-EMHUB02-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob110.postini.com ([64.18.6.12]) with SMTP ID DSNKUFwgnvbuloRzQ8UYmklzA60hdzxLokx7@postini.com; Fri, 21 Sep 2012 01:09:08 PDT Received: from EMBX02-HQ.jnpr.net ([fe80::18fe:d666:b43e:f97e]) by P-EMHUB02-HQ.jnpr.net ([fe80::88f9:77fd:dfc:4d51%11]) with mapi; Fri, 21 Sep 2012 01:00:46 -0700 From: Anuranjan Shukla To: Julian Elischer Date: Fri, 21 Sep 2012 01:00:44 -0700 Thread-Topic: Proposal for changes to network device drivers and network stack (RFC) Thread-Index: Ac2XzzRqHWLEI8AgQJORQYsSLNqh7w== Message-ID: In-Reply-To: <504A1755.6090902@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.2.3.120616 acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "freebsd-net@freebsd.org" Subject: Re: Proposal for changes to network device drivers and network stack (RFC) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2012 08:09:09 -0000 On 9/7/12 8:48 AM, "Julian Elischer" wrote: >>>> struct socket { >>>> >>>> int so_fibnum; /* routing domain for this socket */ >>>> uint32_t so_user_cookie; >>>> + u_int so_oqueue; /* manage send prioritizing based on >>>> application >>>> needs */ >>>> + u_short so_lrid; /* logical routing */ >>>> }; >>>> >>> >We have the second one with the SETFIB socket option, which allows >a socket to select the routing instance (fib) to use. > >it's in the diff, 3 lines up. Thanks Julian. I had wondered if our usage of so_lrid was different enough to justify another field, primarily because I wasn't sure about potential clash with setfib() for the process (since Junos doesn't use it). Having looked a bit more into setfib() after your comment, it looks ok for Junos to use so_fibnum. I'll remove so_lrid from our diff.