From owner-freebsd-net Wed May 2 12:55:48 2001 Delivered-To: freebsd-net@freebsd.org Received: from mail.chem.msu.ru (mail.chem.msu.ru [195.208.208.19]) by hub.freebsd.org (Postfix) with ESMTP id 72C2C37B423 for ; Wed, 2 May 2001 12:55:45 -0700 (PDT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su ([158.250.32.97]) by mail.chem.msu.ru with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id JSFALZ6V; Wed, 2 May 2001 23:54:56 +0400 Received: (from yar@localhost) by comp.chem.msu.su (8.11.1/8.11.1) id f42Jsx452743; Wed, 2 May 2001 23:54:59 +0400 (MSD) (envelope-from yar) Date: Wed, 2 May 2001 23:54:58 +0400 From: Yar Tikhiy To: Matthew Emmerton Cc: alex , freebsd-net@FreeBSD.ORG Subject: Re: no free() after malloc() in arp (src/usr.sbin/arp/arp.c) Message-ID: <20010502235458.A45785@comp.chem.msu.su> References: <824983177.988667461@[192.168.2.94]> <015b01c0d1e9$2557a560$1200a8c0@gsicomp.on.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <015b01c0d1e9$2557a560$1200a8c0@gsicomp.on.ca>; from matt@gsicomp.on.ca on Mon, Apr 30, 2001 at 10:48:01PM -0400 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Mon, Apr 30, 2001 at 10:48:01PM -0400, Matthew Emmerton wrote: > > > i don't see a security issue in this, just want to ask if this is ok (or > > maybe unwanted?): > > > > in src/usr.sbin/arp/arp.c in function search() (starts line ~429) i see > > this (line ~447): > > > > if ((buf = malloc(needed)) == NULL) > > > > this allocated memory isn't free'd later in this function. so if arp uses > > this function over and over again, memory fills up (not much, but it > does). > > This has been reported with a fix in PR bin/27001. > http://www.freebsd.org/cgi/query-pr.cgi?pr=27001 Thanks, committed to -current. -- Yar To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message