From owner-cvs-src@FreeBSD.ORG Sun Dec 7 22:30:44 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2708316A4CE; Sun, 7 Dec 2003 22:30:44 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62EBC43FDF; Sun, 7 Dec 2003 22:30:37 -0800 (PST) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id C7A072ED45F; Sun, 7 Dec 2003 22:30:32 -0800 (PST) Date: Sun, 7 Dec 2003 22:30:32 -0800 From: Paul Saab To: Nate Lawson Message-ID: <20031208063032.GA78971@elvis.mu.org> References: <20031208051448.87BCD16A53C@hub.freebsd.org> <20031207221626.L36956@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031207221626.L36956@root.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Paul Saab cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2003 06:30:44 -0000 Nate Lawson (nate@root.org) wrote: > Please place quirks in the proper section. I believe you put that one in > the USB section. It would also help if you described what happens when > they are sent a SYNC_CACHE (i.e. hang). Most useful would be a PR entry > with the dmesg and description of the behavior. The reason for this is > that especially in the USB case, many quirks had proliferated that were > overly wildcarded and which weren't actually needed but there was no way > to be certain which were needed and which weren't. It would be nice to > know when we can remove the quirk if this turns out to be an underlying > driver problem and not a drive problem. Sorry, I didn't notice this.. I was just taking the code from the Y! tree and didn't realize it had been reorg'd in this way. As for what I am trying to accomplish, the CISS controller doesn't support SYNC_CACHE at all. CISS only supports a small subset of the scsi spec. The driver tries to fake it, but I have found it is unsafe to flush the cache except on reboot.