From nobody Mon Jul 7 15:20:27 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbSc12Hmyz61xGX; Mon, 07 Jul 2025 15:20:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbSc10DSRz462S; Mon, 07 Jul 2025 15:20:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-7d219896edeso394641285a.1; Mon, 07 Jul 2025 08:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751901631; x=1752506431; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=9fhIJyo7yvxDdwkSTIFbZXyr6FGbnoq3MgkAw8KKwKs=; b=bNNW/WfhCpi0QfrqwBAKZxfubvAwsSnMy1kJtP6b+YyFN/3+OrvJM8927YbYEedYFX sxo+FSBUL7sqGxNP5yijvZWf3YJeh6NxajlmeVSa43yycmigdCoPIfPCNuCfEcuD9GFc ovj2zjfOq03ybfWIeptMj3OhDzpJ63z8nc9yufUdpYXHR6hKMl2p6J94b2ROuaPTMtlj 37+ncJ0YzKc9LctGA/bVp7JqceVhubjXNmTklkxROJe/eLklf/Xb7KzNi4HHuAlUILzy WTbfmBjvW87MdQvHQiaZKW1p4xxdAjJWagtOphZ8cvMANEG9/nU8JG6rEdY37jPu+cHK 0emQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751901631; x=1752506431; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9fhIJyo7yvxDdwkSTIFbZXyr6FGbnoq3MgkAw8KKwKs=; b=SWRuxs/xzl360w9AhQbkYuF2GJG/ID+R3eZeLRJTlz1QZKIZr4DzCdXr9WBujorubl QBhib6KnbN6q6+IszPtZ/Kv/93CpWTNWlRWhSblo2+wwaZ8cWiD0WWqfXkBKz9XfDcC1 U7sWpXFXCAn7Pspy93C6Q93nLCqcF3fxF6umrd1vVyp50WDO3uFzlMC3gwUnQsOS+76Y m+ew9j1EAXOmExihbi6LVeMaSXbYr8Cd1OvRqZL3j4PC64l29yX8rmFJ5kl8N2Rwqet/ T+vWs/appcuacype/sjsTlTCTKIRvoWsXUj0Gzfl24jN0qO3Nv4Vizlpo51h7KF9QnHB 5pQw== X-Forwarded-Encrypted: i=1; AJvYcCVbaHLO32QlZK0a1pStNYJ4RTwtLI9Nd92CqdTKdfqvi33bRmn/oz/4OV8zwKm6YxKhds5S/GxNe5C5DZTU+daEaW1+@freebsd.org, AJvYcCViso2m3BTyapem8FNKscM/oFw54HlPKFiPgADrHYdIOXEdcMZ8D5+/nyPBhuSUgUXxyQ4EAOs18mtFLIMwAlu15Rk3Mg4=@freebsd.org X-Gm-Message-State: AOJu0YwzELA6lLBWRzd1+Cf3WRZg1K8q1BvElzpUSD6FIEt8SSfYsyVc LLo1rzpX1KmT+INg9gzR8NqJf4AUABcURLquSeHfkplTU0QaCGooCKcYe9cHS5yP X-Gm-Gg: ASbGncs/hlmmvFAJBC8H/HC3YT85lEKNVgSbJlVMr9IzVewjQVbM0UiyMFCLZURlfcx lhBzLUE0DWKto1jI4sleM6lQpFPyFP/Om+z2vLXvZEg/1ZoOAwYi5GET62UvJAfNaVjtif+BYe1 xXe4q+u4FWX9dsxTX0ehuevdqDBJCqSj0o1fFKNC8NvABEBZHYU2fkYMl0RB2Z+PdU0s8EtWUKw NLwfEZrQih0ZMHOmCYNXX/w++nW68iXCb34N50AKgz12PLteKVYrh4fAblpBI4NJuKUuxnAxsE8 0Y0s0JAzd9H0ucPcI+eaGxT1mAVwTAGfCVkyJVbzqd9q5S1o81NJQC3ofViOQQrQTZxK7M03lj4 U X-Google-Smtp-Source: AGHT+IF/lCkB7cQJ6SHtt2roUZjLPflfYlrq/kE4djsNc1zZ3imfcz9atP3tk9Q8UgOr9n1Cg+zPsA== X-Received: by 2002:a05:6214:f65:b0:702:bf0a:b9d8 with SMTP id 6a1803df08f44-702d169572emr132313176d6.13.1751901631096; Mon, 07 Jul 2025 08:20:31 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702d5e53246sm35623116d6.1.2025.07.07.08.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 08:20:30 -0700 (PDT) Date: Mon, 7 Jul 2025 11:20:27 -0400 From: Mark Johnston To: Shawn Webb Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 71a0af25a535 - main - libopenbsd: Add recallocarray() Message-ID: References: <202507062318.566NIhSM031303@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4bbSc10DSRz462S X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Mon, Jul 07, 2025 at 03:13:29PM +0000, Shawn Webb wrote: > Hey Mark, > > I've noted a couple things. > > On Sun, Jul 06, 2025 at 11:18:43PM +0000, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=71a0af25a5353f929521cb04c73a7266ac5b7b61 > > > > commit 71a0af25a5353f929521cb04c73a7266ac5b7b61 > > Author: Ricardo Branco > > AuthorDate: 2025-06-16 21:41:48 +0000 > > Commit: Mark Johnston > > CommitDate: 2025-07-06 23:09:00 +0000 > > > > libopenbsd: Add recallocarray() > > > > Reviewed by: kib > > MFC after: 1 month > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1698 > > That appears to be the PR for POSIX O_CLOFORK. Correct. > > --- > > lib/libopenbsd/Makefile | 3 +- > > lib/libopenbsd/recallocarray.c | 82 ++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 84 insertions(+), 1 deletion(-) > > FreeBSD commit 450dfafb1519ae7bb0615368ba45813bcabb9b35 back in 2015 > imported a different version of OpenBSD's reallocarray into libc. > Would it make sense to have only one reallocarray implementation? Or > what's the justification for having two implementations of the same > function? What might happen if someone links against both libc and > libopenbsd? Note, this is recallocarray(), not reallocarray(). libc has the latter, this commit added an implementation of the former to libopenbsd.