From owner-freebsd-net@freebsd.org  Sun Jan 10 08:54:19 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07311A69E99
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Sun, 10 Jan 2016 08:54:19 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.rbsd.freebsd.org (unknown
 [IPv6:2607:fc50:2000:101::1bb:73])
 by mx1.freebsd.org (Postfix) with ESMTP id EA67D1EB3
 for <freebsd-net@freebsd.org>; Sun, 10 Jan 2016 08:54:18 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.rbsd.freebsd.org (Postfix, from userid 1346)
 id E7CF4331E8FC; Sun, 10 Jan 2016 08:54:18 +0000 (UTC)
Date: Sun, 10 Jan 2016 08:54:18 +0000
To: freebsd-net@freebsd.org
From: "delphij (Xin Li)" <phabric-noreply@FreeBSD.org>
Reply-to: D4824+325+0b1ea329f3d380e8@reviews.freebsd.org
Subject: [Differential] [Updated] D4824: hyperv/hn: Implement LRO
Message-ID: <187d0312975a0aa9cfef8621afcec18f@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-comment>
Thread-Topic: D4824: hyperv/hn: Implement LRO
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-sqhepmmg5rsjiyy5slol>
X-Phabricator-To: <PHID-USER-aojo5yplx3m2nkpgwndr>
X-Phabricator-To: <PHID-USER-4lzxzqflpaankb5hk2y4>
X-Phabricator-To: <PHID-USER-22avn2hssqzufmcg2crf>
X-Phabricator-To: <PHID-USER-57eqaez2c2qhlyhs4xoi>
X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-Cc: <PHID-USER-dyyyzfp34mimhzvg33tk>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-2vc6la7nxrbxz7f6mnl6-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-2vc6la7nxrbxz7f6mnl6-req@FreeBSD.org>
Thread-Index: MTc5M2I0ZWQ4MDNkYjdlMTJiMjY5YThlMzIwIFaSHDo=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2016 08:54:19 -0000

delphij added a comment.


  Looks good to me overall, consider this as a formal approval if there is no objection from Adrian by Monday.
  
  Could you please take a look at my inline comments and address them if they are reasonable?

INLINE COMMENTS
  sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:186 Will it be sensible to turn this into SYSCTL_INT with CTLFLAG_RDTUN, so users can check its value?
  sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:410 Looks like this is never defined, but a quick glance suggests it won't hurt to have these code?  Can these be unifdef -D'ed (unconditionally compiled in)?

REVISION DETAIL
  https://reviews.freebsd.org/D4824

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, adrian, royger, decui_microsoft.com, howard0su_gmail.com, kmacy, honzhan_microsoft.com, delphij
Cc: freebsd-net-list