; d=freebsd.org; t=1760336239; a=rsa-sha256; cv=none; b=TFO+8KFPCktYBlHLlCai9utEjBEM/IGZEVdqSTUOLXNC4OIPVZmLW/lMto8aXTbW7UY5T7 sKkMkglZsaWtD9Mf/WscKERw323fqfHTe27QGHmqF+zbClzjSD4aVg7vGDEI2pQ5haLv3Q 44+nSNnVBg53lcI+75uwDkWHhPENlPdR/LYFXRpIj7dwLXZpgaVIONVL6CHWruiho8EMai XKYJDdM3/pZ2pZx4hDVBFdAja54yb38q6DTeYko/RfPzxx78ayl3AKyjHljP/Hv1VZ1e9u pz+EkeL92UAkGZufAVwrFrMLE6Rf+iiLhjeVAAPrkUO9eDv9jpCyzJimlSL5aA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4clRvz0xQZzv3P; Mon, 13 Oct 2025 06:17:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59D6HJqp098757; Mon, 13 Oct 2025 06:17:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59D6HJ8Y098754; Mon, 13 Oct 2025 06:17:19 GMT (envelope-from git) Date: Mon, 13 Oct 2025 06:17:19 GMT Message-Id: <202510130617.59D6HJ8Y098754@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 96e0a62abd93 - main - nvme: Use unsigned List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 96e0a62abd93664ad52d18a899f83cd866793a90 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=96e0a62abd93664ad52d18a899f83cd866793a90 commit 96e0a62abd93664ad52d18a899f83cd866793a90 Author: Warner Losh AuthorDate: 2025-10-13 06:12:36 +0000 Commit: Warner Losh CommitDate: 2025-10-13 06:15:51 +0000 nvme: Use unsigned CI complains about signed/unsigned comparisons, but normal build does not. Fix this by transitioning to unsigned and using a loop-scoped variable. Fixes: d714732b598b Sponsored by: Netflix --- sys/dev/nvme/nvme.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/nvme/nvme.h b/sys/dev/nvme/nvme.h index 557b4df4c328..f4ea08f129c0 100644 --- a/sys/dev/nvme/nvme.h +++ b/sys/dev/nvme/nvme.h @@ -2153,8 +2153,6 @@ static inline void nvme_namespace_data_swapbytes(struct nvme_namespace_data *s __unused) { #if _BYTE_ORDER != _LITTLE_ENDIAN - int i; - s->nsze = le64toh(s->nsze); s->ncap = le64toh(s->ncap); s->nuse = le64toh(s->nuse); @@ -2173,7 +2171,7 @@ void nvme_namespace_data_swapbytes(struct nvme_namespace_data *s __unused) s->anagrpid = le32toh(s->anagrpid); s->nvmsetid = le16toh(s->nvmsetid); s->endgid = le16toh(s->endgid); - for (i = 0; i < nitems(s->lbaf); i++) + for (unsigned i = 0; i < nitems(s->lbaf); i++) s->lbaf[i] = le32toh(s->lbaf[i]); #endif }