Date: Thu, 10 Nov 2011 13:15:57 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227394 - in head/sys: amd64/amd64 i386/i386 Message-ID: <20111110121557.GC1659@garage.freebsd.pl> In-Reply-To: <20111110100839.GK50300@deviant.kiev.zoral.com.ua> References: <201111091725.pA9HPhXh092218@svn.freebsd.org> <20111109173128.GF50300@deviant.kiev.zoral.com.ua> <20111110062322.GA1696@garage.freebsd.pl> <20111110100839.GK50300@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--9UV9rz0O2dU/yYYn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 10, 2011 at 12:08:39PM +0200, Kostik Belousov wrote: > On Thu, Nov 10, 2011 at 07:23:23AM +0100, Pawel Jakub Dawidek wrote: > > On Wed, Nov 09, 2011 at 07:31:28PM +0200, Kostik Belousov wrote: > > > On Wed, Nov 09, 2011 at 05:25:43PM +0000, Konstantin Belousov wrote: > > > > Author: kib > > > > Date: Wed Nov 9 17:25:43 2011 > > > > New Revision: 227394 > > > > URL: http://svn.freebsd.org/changeset/base/227394 > > > >=20 > > > > Log: > > > > Stopped process may legitimately have some threads sleeping and n= ot > > > > suspended, if the sleep is uninterruptible. > > > Even more, stopped process might have some threads still running in t= he > > > kernel mode, or inhibited due to wait on blockable locks. I was unable > > > to design an expression that would assert that such thread will be st= opped > > > at the kernel->user boundary. > > >=20 > > > The assertion itself is useful and catched several bugs, but theoreti= cally > > > can cause false positives. If any report of the fired assert for kern= el-mode > > > thread is provided, I will remove the assertions. > >=20 > > If in five years some change will make it to fire and you won't be > > around, nobody will remember this e-mail of yours and someone will spend > > time on looking for a bug that doesn't exist. > >=20 > > If we know it can cause false positives, I'd be in favour of removing it > > or changing it into a warning or at the very least moving this > > information into commit log. > Yes, I do agree that removing the assertion is the most straightforward > solution, but on the assertion already catched more real bugs then > caused headaches (my headache, BTW). Either I change the third or conditi= on > to plain P_SHOULDSTOP(), or create a way to assert exactly what I need. Maybe it would be easier to implement entire check in a function where you have more flexibility and just use function's result in assertion? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --9UV9rz0O2dU/yYYn Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk67wHwACgkQForvXbEpPzRnmACguMu0LvQfHiu6Flkol5Bew5ys vQQAn3FIvYHUSyF6U6zWpnYbtw93c8SY =+fgY -----END PGP SIGNATURE----- --9UV9rz0O2dU/yYYn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111110121557.GC1659>