From owner-freebsd-current@FreeBSD.ORG Tue Nov 11 19:28:39 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2F4D7F96 for ; Tue, 11 Nov 2014 19:28:39 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0A822FA7 for ; Tue, 11 Nov 2014 19:28:39 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8B0B9B941; Tue, 11 Nov 2014 14:28:37 -0500 (EST) From: John Baldwin To: freebsd-current@freebsd.org Subject: Re: r273918 buildworld broke at semaphore Date: Tue, 11 Nov 2014 13:33:05 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <1414786086662-5961241.post@n5.nabble.com> In-Reply-To: <1414786086662-5961241.post@n5.nabble.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201411111333.05910.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 11 Nov 2014 14:28:37 -0500 (EST) Cc: Beeblebrox X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2014 19:28:39 -0000 On Friday, October 31, 2014 4:08:06 pm Beeblebrox wrote: > First breakage in a long time. Error is: > > In file included from cancelpoints_sem_new.c:47: > /usr/src/lib/libc/../../include/semaphore.h:41:16: error: field has > incomplete type 'struct _usem2' > struct _usem2 _kern; > ^ > /usr/src/lib/libc/../../include/semaphore.h:41:9: note: forward declaration > of 'struct _usem2' > struct _usem2 _kern; > ^ > cancelpoints_sem_new.c:66:33: error: use of undeclared identifier > 'USEM_MAX_COUNT' > _Static_assert(SEM_VALUE_MAX <= USEM_MAX_COUNT, "SEM_VALUE_MAX too large"); > ^ > cancelpoints_sem_new.c:335:15: warning: implicit declaration of function > 'USEM_COUNT' is invalid in C99 [-Wimplicit-function-declaration] > *sval = (int)USEM_COUNT(sem->_kern._count); > ^ > cancelpoints_sem_new.c:342:23: error: use of undeclared identifier > 'UMTX_OP_SEM2_WAKE' > return _umtx_op(sem, UMTX_OP_SEM2_WAKE, 0, NULL, NULL); > ^ > cancelpoints_sem_new.c:361:23: error: use of undeclared identifier > 'UMTX_OP_SEM2_WAIT' > return _umtx_op(sem, UMTX_OP_SEM2_WAIT, 0, > ^ > cancelpoints_sem_new.c:445:14: error: use of undeclared identifier > 'USEM_HAS_WAITERS' > if (count & USEM_HAS_WAITERS) > ^ > 1 warning and 5 errors generated. Seems like your tree is not fully up to date? The changes to sem_new.c were committed in the same commit as the changes to sys/umtx.h. -- John Baldwin