From owner-svn-src-all@freebsd.org Fri Aug 25 18:09:40 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74F00DDDECE for ; Fri, 25 Aug 2017 18:09:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3812F6A295 for ; Fri, 25 Aug 2017 18:09:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x236.google.com with SMTP id 81so1755838ioj.5 for ; Fri, 25 Aug 2017 11:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=IlMKhgy+ah0s3L0qC+4VwIMgXbK+j8E0xRJ/T92kG+Y=; b=bWasdCrCmsam3OfMlqh7MtYVAoMjl/D0CKWQvbD/o+xm+S8oIcsyYMzEG+xLZ6Fc0G OleVP9OX3GkcJX9Dj12P/kzhqmqfEM34Yb1PrMn4oYSpWT8567jY9asjGhDx9V7VyhFP ewh8XRvLNUsBKaCl75e8/uqlTA5He6bs8CjtL1wVpgZsWfu1jVJBJnwT1GkbQAfwJsFR fg6d25T12RQoXQGu/E2H4/N/7IkAuZ8LNAZ0DnNrBzaqvpbZAr7EgCOoq/sie1ZOK2CG rGyTPVif4U/Oq4LhvVRiYtVfnIC7F30O++zLTlMRBZ1Df1d1j9r6VzvoeWLjyh/ubioL +FfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=IlMKhgy+ah0s3L0qC+4VwIMgXbK+j8E0xRJ/T92kG+Y=; b=f8NtKoUQmF9/VH6YtcTPVUbcrG5wb7SIF2p1AfXh4cfGZhOg5Vp8x/oMB2Mpn8gLC9 vo9NZXwYDaso1dYnCwEDSnqU+yohbMFGluih/5iNBdLkaeMo0LNvgryStZ+y6HgaKO2y PjjDlwx3cPPV8R1sdZw16mMYuJ5FRlmbz40SY4e/XGK6LVDRS0Oi7bhAYYWlxbWuwEu+ NAN4YcnNuT6nocdCktkalP1DJ569Ar6t3qXGAWggRRO1mk4M7UVfB+Zq6rR+fWE1xw2q bAKsVUz43aDfHJKOj/9xnCUJtHjU8SD3M1mV3d2vrbVxZoHtvjQa+0rGyLu08kNmZl6U bK7A== X-Gm-Message-State: AHYfb5h5JrjchW2ZIG4kXbjAG4BIsSl/U+Bf/y7K8IAsfeaiXmxJ+HgF JYzTBjha/g4RKrjbxYA4PQSLrDxrH2LI X-Received: by 10.107.131.219 with SMTP id n88mr8847612ioi.277.1503684579474; Fri, 25 Aug 2017 11:09:39 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.10.71 with HTTP; Fri, 25 Aug 2017 11:09:38 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <4b016f89-61c5-fc8a-a36a-aca8166c369e@gmail.com> References: <201708251531.v7PFVtoZ038242@repo.freebsd.org> <4b016f89-61c5-fc8a-a36a-aca8166c369e@gmail.com> From: Warner Losh Date: Fri, 25 Aug 2017 12:09:38 -0600 X-Google-Sender-Auth: 4SFIqmYFJ93SZ4IenIDEILimWWw Message-ID: Subject: Re: svn commit: r322893 - head/bin/dd To: Matt Joras Cc: "Conrad E. Meyer" , Alan Somers , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 18:09:40 -0000 On Fri, Aug 25, 2017 at 12:02 PM, Matt Joras wrote: > On 08/25/2017 10:17, Conrad Meyer wrote: > > This change seems to break buildworld on MIPS: > > > > /home/cem/head.svn/bin/dd/args.c: In function 'f_bs': > > /home/cem/head.svn/bin/dd/args.c:188: warning: format '%zd' expects > > type 'signed size_t', but argument 3 has type 'long int' > > /home/cem/head.svn/bin/dd/args.c: In function 'f_cbs': > > /home/cem/head.svn/bin/dd/args.c:199: warning: format '%zd' expects > > type 'signed size_t', but argument 3 has type 'long int' > > /home/cem/head.svn/bin/dd/args.c: In function 'f_ibs': > > /home/cem/head.svn/bin/dd/args.c:245: warning: format '%zd' expects > > type 'signed size_t', but argument 3 has type 'long int' > > /home/cem/head.svn/bin/dd/args.c: In function 'f_obs': > > /home/cem/head.svn/bin/dd/args.c:266: warning: format '%zd' expects > > type 'signed size_t', but argument 3 has type 'long int' > > > > (Yes, it's odd that the SSIZE_MAX constant has 'long' type.) > > > SSIZE_MAX should have type long, since ssize_t is a long on mips (and > other arches besides i386 and arm). > > Re: the build failure, that's in the GCC C format string checking, so > perhaps it's more accurate to say this breaks the (in-tree) GCC build. > %zd is the right format specifier for ssize_t. I guess GCC's format > string checking is getting confused because SSIZE_MAX is a constant that > expands to type long. Perhaps casting to ssize_t would GCC happier, but > that looks rather wrong. > This is why it was cast in the first place due to issues with exact type. Maybe we should put the casts back for the printfs. Warner