From owner-svn-src-all@freebsd.org Sat Dec 19 13:52:28 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B7D844C858B; Sat, 19 Dec 2020 13:52:28 +0000 (UTC) (envelope-from steffen@sdaoden.eu) Received: from sdaoden.eu (sdaoden.eu [217.144.132.164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CynH04GHNz3lXr; Sat, 19 Dec 2020 13:52:28 +0000 (UTC) (envelope-from steffen@sdaoden.eu) Received: by sdaoden.eu (Postfix, from userid 1000) id 33FB516058; Sat, 19 Dec 2020 14:52:26 +0100 (CET) Date: Sat, 19 Dec 2020 14:52:25 +0100 From: Steffen Nurpmeso To: Kevin Bowling Cc: Ian Lepore , Jessica Clarke , Konstantin Belousov , Mateusz Piotrowski <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368714 - head/lib/libc/string Message-ID: <20201219135225.B6y3g%steffen@sdaoden.eu> In-Reply-To: References: <202012171241.0BHCfl1r008452@repo.freebsd.org> <686CF2E6-1D3C-4A83-A323-02CD9F536675@freebsd.org> <452cbb1060b7134315999c2323ed431714dc03fe.camel@freebsd.org> Mail-Followup-To: Kevin Bowling , Ian Lepore , Jessica Clarke , Konstantin Belousov , Mateusz Piotrowski <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org User-Agent: s-nail v14.9.20-84-g7268a84d OpenPGP: id=EE19E1C1F2F7054F8D3954D8308964B51883A0DD; url=https://ftp.sdaoden.eu/steffen.asc; preference=signencrypt BlahBlahBlah: Any stupid boy can crush a beetle. But all the professors in the world can make no bugs. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4CynH04GHNz3lXr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Dec 2020 13:52:28 -0000 Kevin Bowling wrote in : |On Thu, Dec 17, 2020 at 9:33 AM Ian Lepore wrote: |> On Thu, 2020-12-17 at 18:22 +0200, Konstantin Belousov wrote: |>> On Thu, Dec 17, 2020 at 01:01:01PM +0000, Jessica Clarke wrote: |>>> On 17 Dec 2020, at 12:53, Konstantin Belousov |>>> wrote: |>>>> On Thu, Dec 17, 2020 at 12:41:47PM +0000, Mateusz Piotrowski |>>>> wrote: |>>>>> Author: 0mp (doc,ports committer) |>>>>> Date: Thu Dec 17 12:41:47 2020 |>>>>> New Revision: 368714 |>>>>> URL: https://svnweb.freebsd.org/changeset/base/368714 ... |>>>>> + return (0); |>>>> |>>>> return (0) is redundand. ... |>> Why it is bad practice ? |>> |>> C is a small language, and while knowing some quirks (like this one) |>> seems to be optional, others are not. And worse, that other quirks are ... |> How obscure is this quirk? I've been writing C code since 1983, |> including having released a freeware compiler (pre-gcc days) and |> working on a commercial C compiler. I used to moderate the c_language |> conference on BIX (back when that was a thing). I make my living |> writing C and C++ code every day. And yet, I had completely forgotten |> about this quirk. ... |In Kib=E2=80=99s defense I think this is commonly mentioned in C99 books = (at least |that=E2=80=99s where I learned of it) so it depends on when and where som= eone |learned. There are merits approaches of being explicit or brief. I have Nicely said. K&R C 2nd Ed. explicitly uses return(0) many times. --steffen | |Der Kragenbaer, The moon bear, |der holt sich munter he cheerfully and one by one |einen nach dem anderen runter wa.ks himself off |(By Robert Gernhardt)