From owner-freebsd-current Sat Feb 1 22:39:24 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F039037B401 for ; Sat, 1 Feb 2003 22:39:22 -0800 (PST) Received: from nycsmtp2out.rdc-nyc.rr.com (nycsmtp2out.rdc-nyc.rr.com [24.29.99.223]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E6D443F3F for ; Sat, 1 Feb 2003 22:39:22 -0800 (PST) (envelope-from mishchea@driftin.net) Received: from porch.driftin.net (66-108-249-254.nyc.rr.com [66.108.249.254]) by nycsmtp2out.rdc-nyc.rr.com (8.12.1/Road Runner SMTP Server 1.0) with ESMTP id h126Y2UK011739 for ; Sun, 2 Feb 2003 01:34:02 -0500 (EST) Received: by porch.driftin.net (Postfix, from userid 2000) id 850E45A01; Sun, 2 Feb 2003 01:44:18 +0000 (GMT) Date: Sun, 2 Feb 2003 01:44:18 +0000 From: Andrew Mishchenko To: current@freebsd.org Subject: Re: Style fixups for proc.h by andrew@driftin.net Message-ID: <20030202014418.GA25928@driftin.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.3i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat 01 Feb, Matthew Dillon wrote: > Well, there is something to be said for trying to avoid userland > namespace pollution, but it is still somewhat of a stretch since most > userland programs #include standard and system headers before > they #include their own, and the includes are typically done before > any code. > > But I see no reason why the underscore methodology would need to be > used for kernelland prototypes. C has its problems and we need to live > with them, but we shouldn't have to add bogus underscores to prototyped > arguments to work around those problems. I'd prefer normally named > arguments but if I were given only a choice between underscored named > arguments and unnamed arguments, I'd take unnamed arguments hands down. As has been said earlier in this thread, having named arguments can often help new coders learn and help readability (one knows what an argument is for from looking at the header file as opposed to having to look through the C file), which is why I suggested having underscored named arguments when they are useful to have named, and no names when naming them is not useful. Andrew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message