From owner-svn-src-all@freebsd.org Wed Oct 21 15:54:43 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11547A1B4F8; Wed, 21 Oct 2015 15:54:43 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CB4D02B6; Wed, 21 Oct 2015 15:54:42 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id B0D3A1FE023; Wed, 21 Oct 2015 17:54:39 +0200 (CEST) Subject: Re: svn commit: r289700 - in head/sys/compat/linuxkpi: . common common/include common/include/asm common/include/linux common/src To: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201510211501.t9LF1phM000793@repo.freebsd.org> <5627AF01.8070501@FreeBSD.org> <5627B1B5.30607@selasky.org> <5627B24A.4010905@FreeBSD.org> From: Hans Petter Selasky Message-ID: <5627B5A4.70800@selasky.org> Date: Wed, 21 Oct 2015 17:56:20 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5627B24A.4010905@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 15:54:43 -0000 On 10/21/15 17:42, Bryan Drewery wrote: > On 10/21/2015 8:39 AM, Hans Petter Selasky wrote: >> On 10/21/15 17:28, Bryan Drewery wrote: >>> On 10/21/2015 8:01 AM, Hans Petter Selasky wrote: >>>> Author: hselasky >>>> Date: Wed Oct 21 15:01:51 2015 >>>> New Revision: 289700 >>>> URL: https://svnweb.freebsd.org/changeset/base/289700 >>>> >>>> Log: >>>> Start process of moving the LinuxKPI into the default kernel build by >>>> creating an empty directory tree. >>>> >>>> Sponsored by: Mellanox Technologies >>>> >>>> Added: >>>> head/sys/compat/linuxkpi/ >>>> head/sys/compat/linuxkpi/common/ >>>> head/sys/compat/linuxkpi/common/include/ >>>> head/sys/compat/linuxkpi/common/include/asm/ >>>> head/sys/compat/linuxkpi/common/include/linux/ >>>> head/sys/compat/linuxkpi/common/src/ >>>> >>> >>> This makes me think a branch should be used instead. >>> >> >> Most of what will be done is "svn mv" out of "sys/ofed" and changing >> some include paths in sys/modules and sys/conf . Can you explain why you >> think a branch is required ? > > Because you're splitting commits up that should otherwise not be split > up. There's no reason to commit empty directories before a 'svn mv' into > them. OK, I see. Do you want me to revert the "svn add" and put it altogether in a single commit, or is not not that big deal if I keep the next linuxkpi file moving as a single commit? --HPS