From owner-freebsd-current@FreeBSD.ORG  Tue Jan  1 08:41:28 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
 by hub.freebsd.org (Postfix) with ESMTP id 5E71BAF7
 for <freebsd-current@freebsd.org>; Tue,  1 Jan 2013 08:41:28 +0000 (UTC)
 (envelope-from bf1783@googlemail.com)
Received: from mail-ia0-f170.google.com (mail-ia0-f170.google.com
 [209.85.210.170])
 by mx1.freebsd.org (Postfix) with ESMTP id 1E8CD8FC13
 for <freebsd-current@freebsd.org>; Tue,  1 Jan 2013 08:41:27 +0000 (UTC)
Received: by mail-ia0-f170.google.com with SMTP id i1so11094465iaa.1
 for <freebsd-current@freebsd.org>; Tue, 01 Jan 2013 00:41:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:reply-to:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=uXfANJo6WAvens9/dIoJQ588W1aSP+XqzqTBCypEZ6w=;
 b=ciXpK4yRCbGU7zZOWfTsbvtTW02luxxZrcVaS0TukK4zQ1LhbBoUdaD7wtSoW5WEWo
 DGi2W7hTBNVHn8C3fg197v8OZ+nIbmzC9OoXrJCKhLOtWXlK4EtX6J2PkIr7I+EufiMR
 tVGuQkdqiLBT4hhjWyQieyCk0w36uLHvzIPQ6z9DVyrEOQP1S7YsFxihmOf7lOxSCx+O
 veKS4eQt7G4HxFDFWH1Far91WAU94pV946nX/9nJhddcNMswsqviWNP/mhxpkw7KwcQ8
 gyVWys15NxFGGMkO7oGMsn5X6NlAAcJ3NWXijswfANp2+g0fy19+ULu+778sTjm9vmjI
 OVmw==
MIME-Version: 1.0
Received: by 10.50.42.232 with SMTP id r8mr31954118igl.100.1357029355587; Tue,
 01 Jan 2013 00:35:55 -0800 (PST)
Received: by 10.50.88.137 with HTTP; Tue, 1 Jan 2013 00:35:55 -0800 (PST)
In-Reply-To: <419702074.1604361.1356956417866.JavaMail.root@erie.cs.uoguelph.ca>
References: <44353525.1604353.1356956294487.JavaMail.root@erie.cs.uoguelph.ca>
 <419702074.1604361.1356956417866.JavaMail.root@erie.cs.uoguelph.ca>
Date: Tue, 1 Jan 2013 08:35:55 +0000
Message-ID: <CAGFTUwPqBaAezMwEC0--waGhB_QVK6emMoCsojUNT1kVrO6YUQ@mail.gmail.com>
Subject: Re: svn commit: r244604 - head/usr.sbin/gssd
From: "b.f." <bf1783@googlemail.com>
To: Rick Macklem <rmacklem@uoguelph.ca>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Garrett Cooper <yanegomi@gmail.com>, freebsd-current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: bf1783@gmail.com
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jan 2013 08:41:28 -0000

On 12/31/12, Rick Macklem <rmacklem@uoguelph.ca> wrote:
> Rick Macklem wrote:
>> Rick Macklem wrote:
>> > Garrett Cooper wrote:
>> > > On Sun, Dec 30, 2012 at 4:49 PM, Rick Macklem
>> > > <rmacklem@uoguelph.ca>
>> > > wrote:
>> > > > bf1783 wrote:
>> > > >> >Author: rmacklem
>> > > >> >Date: Sat Dec 22 23:21:17 2012
>> > > >> >New Revision: 244604
>> > > >> >URL: http://svnweb.freebsd.org/changeset/base/244604

>> > > >> This breaks world built WITHOUT_KERBEROS and WITH_GSSAPI.

>> > > > Could you please test the attached patch.

> Oh, and I've attached the updated patch, rick

Your patch fixes the build problem.  I leave it to you to decide
whether, if gssd is so dependent upon the Kerberos mechanism support,
it should be built at all when base system Kerberos isn't available.
And also, if it is to be built, whether your additions should depend
upon MK_KERBEROS_SUPPORT or MK_KERBEROS (the former is implied by the
latter, but the converse isn't true).

Thanks and Happy New Year,

                            b.