From owner-cvs-src@FreeBSD.ORG  Thu Jun 28 12:57:51 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 37BEA16A41F;
	Thu, 28 Jun 2007 12:57:51 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 0FA3113C46E;
	Thu, 28 Jun 2007 12:57:51 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id BA8D74767F;
	Thu, 28 Jun 2007 08:57:50 -0400 (EDT)
Date: Thu, 28 Jun 2007 13:57:50 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
In-Reply-To: <200706281254.l5SCswtj063484@repoman.freebsd.org>
Message-ID: <20070628135639.Q37694@fledge.watson.org>
References: <200706281254.l5SCswtj063484@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: 
Subject: Re: cvs commit: src/sys/netatalk aarp.h ddp.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2007 12:57:51 -0000

On Thu, 28 Jun 2007, Robert Watson wrote:

> rwatson     2007-06-28 12:54:58 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/netatalk         aarp.h ddp.h
>  Log:
>  Mark wire data structures in netatalk as __packed so that they are
>  properly (un)padded on the arm platform.  With this change, FreeBSD/arm
>  boxes are able to route AppleTalk properly.
>
>  Submitted/tested by:    Nathan Whitehorn <nathanw at uchicago dot edu>
>  Tested on:              arm, i386, amd64
>  Approved by:            re (kensmith)

We've now scattered __packed in a number of protocols, but I can't help but 
wonder if we shouldn't generally be doing a sweep of callers to mtod() to find 
all places where we cast wire data structures to C structures and checking 
padding across platforms.  It would also be good to add more CTASSERT's about 
wire data structure sizes beside their definitions.

Robert N M Watson
Computer Laboratory
University of Cambridge