From owner-freebsd-rc@FreeBSD.ORG  Tue Nov  8 18:47:19 2005
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@freebsd.org
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EB55916A420;
	Tue,  8 Nov 2005 18:47:19 +0000 (GMT)
	(envelope-from maksim.yevmenkin@savvis.net)
Received: from ismybrain.com (ismybrain.com [64.246.42.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 665A043D46;
	Tue,  8 Nov 2005 18:47:17 +0000 (GMT)
	(envelope-from maksim.yevmenkin@savvis.net)
Received: from [10.254.186.111] (localhost.localdomain [127.0.0.1])
	by ismybrain.com (8.11.6/8.11.6) with ESMTP id jA8Il2J19033;
	Tue, 8 Nov 2005 13:47:02 -0500
Message-ID: <4370F2A3.8060808@savvis.net>
Date: Tue, 08 Nov 2005 10:46:59 -0800
From: Maksim Yevmenkin <maksim.yevmenkin@savvis.net>
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050404)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Yar Tikhiy <yar@comp.chem.msu.su>
References: <4367E346.4080106@savvis.net>
	<20051102111709.GD2465@comp.chem.msu.su>
	<20051102161311.GA8499@odin.ac.hmc.edu> <43690365.60909@savvis.net>
	<20051102190655.GA3961@odin.ac.hmc.edu>
	<436A6649.7000602@savvis.net>
	<20051103203217.GA30685@odin.ac.hmc.edu>
	<436BE02D.2020404@savvis.net>
	<20051105113503.GA13863@comp.chem.msu.su>
	<436F9C8B.1000300@savvis.net>
	<20051108183203.GA40364@comp.chem.msu.su>
In-Reply-To: <20051108183203.GA40364@comp.chem.msu.su>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-bluetooth@freebsd.org, freebsd-rc@freebsd.org,
	Panagiotis Astithas <past@ebs.gr>
Subject: Re: [RFC] rc.d integration for the bluetooth subsystem
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Nov 2005 18:47:20 -0000

Yar,

>>if expr "$_line" : "[a-zA-Z0-9_]*=" > /dev/null 2>&1 ; then
>>...
>>fi
>>
>>i do not really have any objection to this. since i already pass the 
>>value through eval i might as well pass the entire line.
> 
> And so the users will be able to use basic sh(1) tricks in the lines.

depending on one's position it may or may not be a good thing :)

>>>And AFAIK stdin to a while loop can be redirected w/o enclosing
>>>the loop in braces.
>>
>>sure, but it looked more clear (to me anyway) this way :)
> 
> Hmmm, I'm unsure if it worked at all ;-)  In sh(1) you need to
> place a ';' before '}' if there is no '\n' after the last command
> in braces.  That is, the sh(1) syntax dictates that you can write

it works. i tried these patches on my system. also there is a similar 
code in /etc/rc.subr (please see devfs_rulesets_from_file() function). 
but if it make sh(1) purists uncomfortable i certainly can change it :)

thanks,
max