From owner-freebsd-ports  Sun Oct  1 13: 0: 5 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 452FD37B66C
	for <freebsd-ports@FreeBSD.org>; Sun,  1 Oct 2000 13:00:01 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id NAA96018;
	Sun, 1 Oct 2000 13:00:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from 200-227-201-106-as.acessonet.com.br (200-227-201-106-as.acessonet.com.br [200.227.201.106])
	by hub.freebsd.org (Postfix) with ESMTP id 8F9EC37B66E
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Oct 2000 12:51:53 -0700 (PDT)
Received: (qmail 85256 invoked by uid 1001); 1 Oct 2000 19:51:46 -0000
Message-Id: <20001001195146.85255.qmail@Fedaykin.here>
Date: 1 Oct 2000 19:51:46 -0000
From: "Mario Sergio Fujikawa Ferreira" <lioux@uol.com.br>
Reply-To: lioux@uol.com.br
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/21684: Port update: Makefile cleaning on astro/xearth
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         21684
>Category:       ports
>Synopsis:       Port update: Makefile cleaning on astro/xearth
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 01 13:00:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Mario Sergio Fujikawa Ferreira
>Release:        FreeBSD 4.0-STABLE i386
>Organization:
>Environment:

FreeBSD Fedaykin.here 4.1-STABLE FreeBSD 4.1-STABLE #10: Sun Sep 24 15:18:36 BRT 2000     lioux@Fedaykin.here:/usr/src/sys/compile/LIOUX  i386

>Description:

The CP command is inadequate for ports style. It was replaced by
INSTALL_DATA.

Besides, it is dependant on the user umask, for some systems this
means that it will install it with wrong permissions for most users.

For the same reason, I added the CHMOD to make sure the other file
is correct.

>How-To-Repeat:

do a umask 077 and then, install it
you are going to get permissions such as 0600 for most files. This
proves impossivel for users other than the installing one to use
the marker files.

>Fix:

--- Makefile.orig	Sun Oct  1 17:43:50 2000
+++ Makefile	Sun Oct  1 17:45:00 2000
@@ -22,11 +22,12 @@
 # Copy the list of FreeBSD sites
 post-install:
 	${MKDIR} ${PREFIX}/lib/X11/xearth
-	${CP} ${FILESDIR}/freebsd.core.markers ${PREFIX}/lib/X11/xearth
-	${CP} ${FILESDIR}/freebsd.committers.markers ${PREFIX}/lib/X11/xearth
-	${CP} ${FILESDIR}/freebsd.ftp.markers ${PREFIX}/lib/X11/xearth
+	${INSTALL_DATA} ${FILESDIR}/freebsd.core.markers ${PREFIX}/lib/X11/xearth
+	${INSTALL_DATA} ${FILESDIR}/freebsd.committers.markers ${PREFIX}/lib/X11/xearth
+	${INSTALL_DATA} ${FILESDIR}/freebsd.ftp.markers ${PREFIX}/lib/X11/xearth
 	${ECHO} "# All of FreeBSD's committers, including core :)" > \
 	    ${PREFIX}/lib/X11/xearth/freebsd.core_and_committers.markers
+	${CHMOD} 0444 ${PREFIX}/lib/X11/xearth/freebsd.core_and_committers.markers
 	${GREP} -hv '^[[:space:]]*#' ${FILESDIR}/freebsd.core.markers \
 	    ${FILESDIR}/freebsd.committers.markers >> \
 	    ${PREFIX}/lib/X11/xearth/freebsd.core_and_committers.markers

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message