Date: Thu, 7 Dec 2017 12:26:57 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Joe Marcus Clarke <marcus@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <20171207122656.k2t2uruhqwrhzt3f@ptrcrt.ch> In-Reply-To: <67778550-ec80-89d4-8914-80d001280e6d@FreeBSD.org> References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> <df5a59b6-df44-9a2c-2a4d-d85b15376a97@freebsd.org> <20171207120403.7wafl635xclviqsr@ptrcrt.ch> <67778550-ec80-89d4-8914-80d001280e6d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--z6uhslesy46g6wvv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Dec 7 17 13:07, Mathieu Arnold wrote: > Le 07/12/2017 =C3=A0 13:04, Pietro Cerutti a =C3=A9crit=C2=A0: > > On Dec 7 17 06:22, Joe Marcus Clarke wrote: > >> On 12/7/17 03:13, Pietro Cerutti wrote: > >>> On Dec 7 17 08:10, Pietro Cerutti wrote: > >>>> On Dec 7 17 08:04, Pietro Cerutti wrote: > >>>>> On Aug 15 17 12:43, Joe Marcus Clarke wrote: > >>>>>> Author: marcus > >>>>>> Date: Tue Aug 15 12:43:14 2017 > >>>>>> New Revision: 447981 > >>>>>> URL: https://svnweb.freebsd.org/changeset/ports/447981 > >>>>>> > >>>>>> Log: > >>>>>> Update to 2.17.12. > >>>>>> @@ -3400,6 +3437,11 @@ sub abspathname { > >>>>>> =20 > >>>>>> if ($pre =3D~ /MASTER_SITE_SUBDIR/) { > >>>>>> # MASTER_SITE_SUBDIR lines are ok. > >>>>>> + $i =3D ''; > >>>>>> + } > >>>>>> + if ($s =3D~ /\$\{[^}]*?$i/) { > >>>>>> + # If we're inside a make variable, we probably do not have > >>>>>> + # an absolute path. > >>>>>> $i =3D ''; > >>>>>> } > >>>>>> } > >>>>>> > >>>>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2= >&1 )=20 > >>>>> <-- HERE / at /usr/local/bin/portlint line 3443. > >>>>> > >>>>> I think the ? doesn't belong there. > >>>> No, my analysis was wrong. It's about the contents of the $i variabl= e.=20 > >>>> Here's why. You can reproduce by portlint -AC in net-im/openfire. > >>>> > >>>> i is /var/log/openfire > >>>> WARN: Makefile: possible use of absolute pathname "/var/log/openfire= ". > >>>> > >>>> i is /var/db/openfire > >>>> WARN: Makefile: possible use of absolute pathname "/var/db/openfire". > >>>> > >>>> i is /dev/null 2>&1 ) > >>>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>= &1 )=20 > >>>> <-- HERE / at /usr/local/bin/portlint line 3444. > >>> Surrounding $i with \Q and \E in the regex solves the problem. > >>> > >>> > >> Thanks. I'll commit a quick fix ahead of the next release. > > Thanks. I still don't understand why you have both * and ? as=20 > > quantifiers, though. >=20 >=20 > perlre(1): >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *?=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Match 0 or more times, not greedily >=20 oh, the non-greedy qualifier, thanks! --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org --z6uhslesy46g6wvv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlopM4wuFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII ntkXEADICUd6FtyKKjBZKO16IX72kdCQ1stM4HIAtWimnSuw3D0twMm0KmhaiMfq gKQMOkdDq1vSIDvdXSRPHAe7nLzzEhUsUYUJDqoJdy5NIEwDkm/CnVolemV4ml6W nqrfjNcYiTszDMkQZBxJmZe5nr3QGYb+MlsjCHvgKiWLG0TUGUSmOLbVRrERyML9 ziyNml8RVUotggL6ZfKZ5/YUo0rv2evkoYNAJJ7fUA4ajI9Dpe5c+IX5mLjBGs+0 ZdN1ftqk/QEoYglnUQXW1ah3sD59KO6d9hLxmxU55rCqQYwbvTh9w/F5xU75tOxq 6JuGZ14D9HkEnnaF5LE7FYextkkD0fkedeE60schxtVMRPuUwzAC6gHlKM8+0z1r 2s2AS8NxkvAAEx8rQXDC+SBCOigI+GT7Ac5C/ZqiapKTv4x/mgCAWYJ/9ra4iXQG yPunEYuqw8fSB5eDUtepp50Fbkx7+tCrH2PmF1buAaL+t7unw3liQZAewrHCgJXL lS5CwcHbaoAg+4ncylbHxpYRLquLIMHR989APhy+qmt7zciAcny088m5bkNc4CZf ikMr/j6At3OmS7CEIMaSCHy5tt7ti64N2as8yD8vzTSREHe3H4j3R1worAJIwhPb myG0Rtl/w8FloyYYPKDvfO9F375rHZQQ05oEpElyh/zwozSCZA== =YBbG -----END PGP SIGNATURE----- --z6uhslesy46g6wvv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171207122656.k2t2uruhqwrhzt3f>