Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 Aug 2012 14:59:10 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        Bryan Drewery <bdrewery@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Roman Bogorodskiy <novel@freebsd.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r302578 - head/security/gnutls
Message-ID:  <503161AE.8070806@FreeBSD.org>
In-Reply-To: <50315B6F.5010407@FreeBSD.org>
References:  <201208151357.q7FDv1RK063257@svn.freebsd.org> <50315B6F.5010407@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 08/19/2012 14:32, Bryan Drewery wrote:
> On 8/15/2012 8:57 AM, Roman Bogorodskiy wrote:
>> Author: novel
>> Date: Wed Aug 15 13:57:01 2012
>> New Revision: 302578
>> URL: http://svn.freebsd.org/changeset/ports/302578
>>
>> Log:
>>   - Drop automatic dependency detection [1]
>>   - Do not link to -lphread directly [2]
>>   - Use USE_PKGCONFIG [2]
> 
> 
> FYI this change to USE_PKGCONFIG=build ends up breaking other ports that
> depend on gnutls and incorrectly do not mark they depend on pkgconfig.
> Something to keep an eye on in general as these are converted.
> 
> textproc/iksemel [ports/170771] is one example.

FWIW the solution I used when changing my non-leaf ports was to delete
pkgconf, then look at every port that depends on them and test if they
passed 'make configure' without any changes. Since so many things depend
on gnutls it may be safer to just add the dependency with a comment in
the Makefile to maintainers to remove it if it turns out not to be
necessary.

<insert obligatory rant about how this whole thing has been poorly handled>

Doug

-- 

    I am only one, but I am one.  I cannot do everything, but I can do
    something.  And I will not let what I cannot do interfere with what
    I can do.
			-- Edward Everett Hale, (1822 - 1909)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?503161AE.8070806>