From owner-svn-ports-all@FreeBSD.ORG Sun Aug 19 21:59:11 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id 389241065670; Sun, 19 Aug 2012 21:59:11 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id F414D14D92F; Sun, 19 Aug 2012 21:59:10 +0000 (UTC) Message-ID: <503161AE.8070806@FreeBSD.org> Date: Sun, 19 Aug 2012 14:59:10 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:14.0) Gecko/20120728 Thunderbird/14.0 MIME-Version: 1.0 To: Bryan Drewery References: <201208151357.q7FDv1RK063257@svn.freebsd.org> <50315B6F.5010407@FreeBSD.org> In-Reply-To: <50315B6F.5010407@FreeBSD.org> X-Enigmail-Version: 1.4.3 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Roman Bogorodskiy , ports-committers@freebsd.org Subject: Re: svn commit: r302578 - head/security/gnutls X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2012 21:59:11 -0000 On 08/19/2012 14:32, Bryan Drewery wrote: > On 8/15/2012 8:57 AM, Roman Bogorodskiy wrote: >> Author: novel >> Date: Wed Aug 15 13:57:01 2012 >> New Revision: 302578 >> URL: http://svn.freebsd.org/changeset/ports/302578 >> >> Log: >> - Drop automatic dependency detection [1] >> - Do not link to -lphread directly [2] >> - Use USE_PKGCONFIG [2] > > > FYI this change to USE_PKGCONFIG=build ends up breaking other ports that > depend on gnutls and incorrectly do not mark they depend on pkgconfig. > Something to keep an eye on in general as these are converted. > > textproc/iksemel [ports/170771] is one example. FWIW the solution I used when changing my non-leaf ports was to delete pkgconf, then look at every port that depends on them and test if they passed 'make configure' without any changes. Since so many things depend on gnutls it may be safer to just add the dependency with a comment in the Makefile to maintainers to remove it if it turns out not to be necessary. Doug -- I am only one, but I am one. I cannot do everything, but I can do something. And I will not let what I cannot do interfere with what I can do. -- Edward Everett Hale, (1822 - 1909)