From owner-freebsd-ports@freebsd.org Wed Jan 17 18:51:59 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4EAC7EA6883 for ; Wed, 17 Jan 2018 18:51:59 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: from mail-lf0-x234.google.com (mail-lf0-x234.google.com [IPv6:2a00:1450:4010:c07::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B46EE7CAB1 for ; Wed, 17 Jan 2018 18:51:58 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: by mail-lf0-x234.google.com with SMTP id o89so19174515lfg.10 for ; Wed, 17 Jan 2018 10:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kUJY9OVZofipp/CSG+vFNghBsyxO8dhY4461nsKpJwk=; b=svwrjgYXH+Z+zmvBCkqixyL0LydwdqClywcCqCPWvsbOm2NarUVIbfJmdHwRCeZujA u/PHUxF4ymq70TVLvNrXCkICoiJwTstd9JKtB4VxfpNA8YLZa6ZxlIh6KgNSmTIdnfqp eWjsoLSmN8UsG5j+vEG2ctW02KfSaoH53Ibv39cI3M7GfVoqoQGK/DOVokXhavtmiauc WE91TAL4DjczqO0A14iHRnVovL8Mj0ZWHeJ8kWZkmi2Th4GfGArZsxkS5GtciIcjE2J9 bMnUPJrEbx0Thew+DplsJ3TAVpHBzuKLKMM2OPZ16RgRc8zfqowUg/FtzH68uMVKgCA/ OQRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kUJY9OVZofipp/CSG+vFNghBsyxO8dhY4461nsKpJwk=; b=F5VeNgdi8Rqn4tSIIk8YOKJTLFsOWuMQLSBTRZuQD+VbSwERpiAufOSwajEom3L0DR Zd8E9QtsUaPiPgJ+wFangAM6q8BZFlMVDV+NppypLlVmtz2XNtN9G0QBGw2uiWxWk6dD 5QpuzxINj53Kb1wLMs0CmXDyXZkkOSzwGMqe6O7OLU2yYYcD0EOYDYvpHl1TFkjF/WZD k9zx84P0g5i90tQDOWrsthQ/9xkDGjL1wWyLicfO72j1uF+FuiJyMAPOs8GLvMDCBi+n pTjgbfHYlU7ihETcaNO06ZLrROYRl18JOJoL+it1HzEzKyrmzkj6v0tl/GAfW5jXkjSa vMfg== X-Gm-Message-State: AKwxytcE1VLMGeDGMIq2pHFP4+aQW2/7+XD694XKvu1kqM1kzcEfdmCE 3jDyL09U9t+Np5OElrtzqToaBkFj47EdW8YFUYXnHw== X-Google-Smtp-Source: ACJfBovX16niHHLpipFe/qIW1KOecv9KF3O0Dq077IiF7B0REzlqysySZpHDvuGe/xwWy5B2rQfRO8vi0FMdhvzECrU= X-Received: by 10.25.211.7 with SMTP id k7mr1020013lfg.118.1516215116650; Wed, 17 Jan 2018 10:51:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.163.207 with HTTP; Wed, 17 Jan 2018 10:51:56 -0800 (PST) In-Reply-To: <638AE69B-CB7C-41E1-9CA8-D0B9E2A6BC32@waschbuesch.de> References: <638AE69B-CB7C-41E1-9CA8-D0B9E2A6BC32@waschbuesch.de> From: Freddie Cash Date: Wed, 17 Jan 2018 10:51:56 -0800 Message-ID: Subject: Re: Help with versioning scheme To: =?UTF-8?Q?Martin_Waschb=C3=BCsch?= Cc: Adam Weinberger , freebsd-ports Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 18:51:59 -0000 On Wed, Jan 17, 2018 at 10:40 AM, Martin Waschb=C3=BCsch wrote: > Thanks, Freddie, > > Am 17.01.2018 um 19:35 schrieb Freddie Cash : > > On Wed, Jan 17, 2018 at 10:29 AM, Martin Waschb=C3=BCsch > wrote: > >> Hi Adam, >> > Am 17.01.2018 um 19:19 schrieb Adam Weinberger : >> > Hi Martin, >> > >> > You don't want to use the upstream version to represent PORTREVISION. >> PORTREVISION is for when you need to force rebuilds of the port itself, = and >> so tying it to upstream would make it impossible to bump it ourselves. >> > >> > Why do you need to ignore the fourth digit? It's perfectly valid for >> our purposes. >> >> So far, I had (because it coincided with their version number) used it t= o >> provide SO_VER. But that breaks now: >> >> --- >> # Created by: adamw >> # $FreeBSD: head/archivers/liblz4/Makefile 448415 2017-08-20 12:30:25Z >> sunpoet $ >> >> PORTNAME=3D lz4 >> PORTVERSION=3D 1.8.1 >> DISTVERSIONPREFIX=3D v >> PORTEPOCH=3D 1 >> CATEGORIES=3D archivers >> PKGNAMEPREFIX=3D lib >> >> MAINTAINER=3D martin@waschbuesch.de >> COMMENT=3D LZ4 compression library, lossless and very fast >> >> LICENSE=3D BSD2CLAUSE GPLv2 >> LICENSE_COMB=3D multi >> >> USES=3D gmake pathfix pkgconfig >> USE_GITHUB=3D yes >> USE_LDCONFIG=3D yes >> #PATHFIX_MAKEFILEIN=3D Makefile >> >> ALL_TARGET=3D default # don't remove this >> SO_VER=3D ${PORTVERSION} >> PLIST_SUB+=3D SO_VER=3D${SO_VER} SO_VER_MAJ=3D${SO_VER:R:R} >> > > =E2=80=8BWhy can't you do something like the above to get SO_VER? > > PORTVERSION=3D1.8.1.2 > SO_VER=3D${PORTVERSION:R:R:R) > > Similar to how you get SO_VER_MAJ out of SO_VER.=E2=80=8B > > > That is true. Do you think this is a robust solution, though? > Or is the whole relying on upstream variables idea problematic? > =E2=80=8BSo long as they continue to have =E2=80=8B4 digit version numbers = (meaning 1.9.0.0 and not just 1.9), then everything will be fine. If upstream does weird things with their version numbers (1.8.1.2 --> 1.8.2 --> 1.9 --> 2 --> 2.1 --> 2.1.1 --> 2.1.1.1), then you'll have to manually massage things in the port Makefile with each update. Hopefully, they don't do that, and keep things logical (1.8.1.2 --> 1.8.2.0 --> 1.9.0.0 --> 2.0.0.0 --> 2.1.0.0 --> 2.1.1.0 --> 2.1.1.1) which would make things simpler on your end. :) --=20 Freddie Cash fjwcash@gmail.com