From owner-svn-src-head@freebsd.org Sat Aug 29 09:44:16 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABC283D35DA; Sat, 29 Aug 2020 09:44:16 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bds4H1pLfz4DqM; Sat, 29 Aug 2020 09:44:14 +0000 (UTC) (envelope-from ohartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598694253; bh=Bxov30qVuC2YzECV5Qq7h8SRPDecyF2CtW/SUdSCAxk=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=bMdxS0r+BTzY4qmt8Coagxj4iv9kSoEPf7PYK3/RR5e8GIOq5eT47REcGQWcy6FuF gb8E/ECYYreFxvw/3KwIc0WSHUwsCNwR8P84gJoQnzatYlbCOxBlGZjXOmcZqs4AhQ ZLXUlFmkisp6Sm/hzp2bfCY6MYJy27FCrRVm3BQE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from hermann.fritz.box ([78.55.153.100]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MD9XF-1kKzoS0NW5-009BOI; Sat, 29 Aug 2020 11:44:13 +0200 Date: Sat, 29 Aug 2020 11:44:04 +0200 From: "Hartmann, O." To: "Alexander V. Chernikov" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364941 - in head/sys: net net/route netinet netinet6 Message-ID: <20200829114404.2fbdb73d@hermann.fritz.box> In-Reply-To: <202008282250.07SMoL7I095754@repo.freebsd.org> References: <202008282250.07SMoL7I095754@repo.freebsd.org> Organization: walstatt.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/BkXhTkDbEWYS4IuN+9OceSu"; protocol="application/pgp-signature" X-Provags-ID: V03:K1:UpUdPCyzXm5Mkp6pbNTxyOl1I6olMtun/KvJLSs2EL4HnRIHkN7 2jG/2kXfGGwUhlaeqQtJUGfHCAoimxBwSWRDqhy139qIpFs/OEiTuf6kHYh/kwd2Zq6chUW 8feq2kxO7DbQKqas6bsyKb8QR1v6K6lBQdVGa6KJuYGbLB1Pb6GK1C7sdYZAYz72eVUztd7 NmlD90KiuSdkYdtFVrL4g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:DA8xGfCGMqY=:zBvrx3XgV8HZZybTfB8ln0 R9CdlbkkFCpkOxq+z+wbf5jYE5S1szRxsWOQ/yEoHy/XS9Nd8LFeebUTDsPVcd3zG+asgM3Yg 93C8AvKxOUT6WlMkeNQgywm1A7ClreTHyt3FAdGG8RMnBDT1AKqtmXwQJLpd8fKZm9vE5/6sc ZyH4R4rUo+v6NQi7Y4bHuk8+aJ9uNndwLJpGiN+eLr/6GfX/Mryr8Y7nYL82siaLmhfMn5kng Muc3XS7MIHPAwsperloaaHiMMOPZOD94hJGrOmxLPE2rzTHQJnwVhs8joEeytkzSzhdo9n8In h7TDfHrYUYKMxZOODX9volxpfuC7ZpEfZxZtQn7zUcE2IDZviQ5Ya202OgvQNl/uOJsSIBSlS ZpYPQpsJGRucxrjAPNFLsT/c8D9soejJiP2vSRHkxOlZMpQ+qLgg+cbMuYHaWYKAmYdkPQvND NZTRQp4bDnWAmckpd44q+x8yhJOpCiPiXT0B9DUOVZBICzNdzp0Gg1iihnNoolSEu62QRTkoi zQ9xcdmXScGSnQyEFv/szfGgf6hflCw3YzHCEEgnL+C1RJ69jug22JvAr2n1GENoLdwt0zWGR oHLAE7Y2J7y7UL1mgTfwxTOlpn/16kbRK24/KK7ZhyyPV6DQ0XqZ9Tgr0yaASqWUSAGF5eRKt bIMNFC2u1HDvAuWqO213n+SOepkid0suF+U76fHAU7Y84U/o/sVjcyBs1RxHTOdOwppRkm5zF 57q9gO+pwV0rvUX0hCuYZbGpa3JK6JVGfpidHXTd5GZX98ZRhaStPRzUCQs4hrv5r9VGNmIZL dh8VVsQmTWibXhGJn/WlZ7WuXjOdcDTYHjppr78UA2+YYeti6aT77gNplL6KPkaKgyokGcxGN aMuibYP08BgHPaEBdhuHLN0Nij97t+OgPnZ8Ui4OufjrjNDIuO5wT5jQEpjGKZ1+2gz03JbuI RQ6/tXsd0Ah9fg8vDWxIDsndHl31J6j8it5ozibRbf3hcmwb2RWhCv8Q+6tugx270ygeCaI2V t6jPGF2E2wDQpUIw/24w6B4r23vLLb5kfjsV/I0Ay98kAJ89lBL+oLxnsUwO6sB7xWG22hoFa AxNq8toy9ppXN71NN9AjCkVqD6ihYFNFUO1ThwKzHbtivKKJuUGp4FfUsJa3xmYPDL6A6IG1P jhqw+m0/LI/7d/iePol3uhSXodfhJ2fMLS6ZV57kV67CbbWAXBpZl2HVRLyb1R/job+qOa+zN /EfZx5fgkB1CK/xHlHjKL6lJFb/VtarTzCxmqFA== X-Rspamd-Queue-Id: 4Bds4H1pLfz4DqM X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=bMdxS0r+; dmarc=none; spf=none (mx1.freebsd.org: domain of ohartmann@walstatt.org has no SPF policy when checking 212.227.17.22) smtp.mailfrom=ohartmann@walstatt.org X-Spamd-Result: default: False [-2.62 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; RWL_MAILSPIKE_POSSIBLE(0.00)[212.227.17.22:from]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[walstatt.org]; ARC_NA(0.00)[]; NEURAL_HAM_LONG(-0.93)[-0.926]; HAS_ORG_HEADER(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[78.55.153.100:received]; NEURAL_HAM_MEDIUM(-0.84)[-0.836]; DKIM_TRACE(0.00)[gmx.net:+]; NEURAL_HAM_SHORT(-0.36)[-0.361]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_IN_DNSWL_LOW(-0.10)[212.227.17.22:from] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Aug 2020 09:44:16 -0000 --Sig_/BkXhTkDbEWYS4IuN+9OceSu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 28 Aug 2020 22:50:21 +0000 (UTC) "Alexander V. Chernikov" wrote: > Author: melifaro > Date: Fri Aug 28 22:50:20 2020 > New Revision: 364941 > URL: https://svnweb.freebsd.org/changeset/base/364941 >=20 > Log: > Move net/route/shared.h definitions to net/route/route_var.h. > =20 > No functional changes. > =20 > net/route/shared.h was created in the inital phases of nexthop > conversion. It was intended to serve the same purpose as route_var.h > - share definitions of functions and structures between the routing > subsystem components. At that time route_var.h was included by many > files external to the routing subsystem, which largerly defeats its > purpose.=20 > As currently this is not the case anymore and amount of route_var.h > includes is roughly the same as shared.h, retire the latter in favour > of the former. >=20 > Deleted: > head/sys/net/route/shared.h > Modified: > head/sys/net/radix_mpath.c > head/sys/net/route.c > head/sys/net/route/nhop.c > head/sys/net/route/nhop_ctl.c > head/sys/net/route/route_ctl.c > head/sys/net/route/route_helpers.c > head/sys/net/route/route_var.h > head/sys/net/rtsock.c > head/sys/netinet/in_fib.c > head/sys/netinet/in_rmx.c > head/sys/netinet6/in6_fib.c > head/sys/netinet6/in6_rmx.c >=20 > Modified: head/sys/net/radix_mpath.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/radix_mpath.c Fri Aug 28 21:59:10 2020 > (r364940) +++ head/sys/net/radix_mpath.c Fri Aug 28 22:50:20 > 2020 (r364941) @@ -56,7 +56,6 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > -#include > #include > #include > #include >=20 > Modified: head/sys/net/route.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/route.c Fri Aug 28 21:59:10 2020 > (r364940) +++ head/sys/net/route.c Fri Aug 28 22:50:20 > 2020 (r364941) @@ -64,7 +64,6 @@ > #include > #include > #include > -#include > #include > =20 > #ifdef RADIX_MPATH >=20 > Modified: head/sys/net/route/nhop.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/route/nhop.c Fri Aug 28 21:59:10 2020 > (r364940) +++ head/sys/net/route/nhop.c Fri Aug 28 22:50:20 > 2020 (r364941) @@ -46,7 +46,6 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > -#include > #include > =20 > /* >=20 > Modified: head/sys/net/route/nhop_ctl.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/route/nhop_ctl.c Fri Aug 28 21:59:10 > 2020 (r364940) +++ head/sys/net/route/nhop_ctl.c Fri > Aug 28 22:50:20 2020 (r364941) @@ -49,7 +49,6 @@ > __FBSDID("$FreeBSD$"); #include > #include > #include > -#include > #include > =20 > /* >=20 > Modified: head/sys/net/route/route_ctl.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/route/route_ctl.c Fri Aug 28 21:59:10 > 2020 (r364940) +++ head/sys/net/route/route_ctl.c Fri > Aug 28 22:50:20 2020 (r364941) @@ -52,7 +52,6 @@ > __FBSDID("$FreeBSD$"); #include > #include > #include > -#include > #include > =20 > #ifdef RADIX_MPATH >=20 > Modified: head/sys/net/route/route_helpers.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/route/route_helpers.c Fri Aug 28 21:59:10 > 2020 (r364940) +++ head/sys/net/route/route_helpers.c > Fri Aug 28 22:50:20 2020 (r364941) @@ -55,7 +55,6 @@ > __FBSDID("$FreeBSD$"); #include > #include > #include > -#include > #ifdef INET > #include > #endif >=20 > Modified: head/sys/net/route/route_var.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/route/route_var.h Fri Aug 28 21:59:10 > 2020 (r364940) +++ head/sys/net/route/route_var.h Fri > Aug 28 22:50:20 2020 (r364941) @@ -39,7 +39,14 @@ > #include > #include /* struct sockaddr_in */ > #include > +#include > =20 > +#ifdef RTDEBUG > +#define DPRINTF(_fmt, ...) printf("%s: " _fmt "\n", > __func__ , ## __VA_ARGS__) +#else > +#define DPRINTF(_fmt, ...) > +#endif > + > struct nh_control; > typedef int rnh_preadd_entry_f_t(u_int fibnum, const struct sockaddr > *addr, const struct sockaddr *mask, struct nhop_object *nh); > @@ -221,6 +228,7 @@ fib_rte_to_nh_flags(int rt_flags) > return (res); > } > =20 > +/* route_temporal.c */ > void tmproutes_update(struct rib_head *rnh, struct rtentry *rt); > void tmproutes_init(struct rib_head *rh); > void tmproutes_destroy(struct rib_head *rh); > @@ -236,5 +244,33 @@ int change_route_conditional(struct rib_head > *rnh, str=20 > void vnet_rtzone_init(void); > void vnet_rtzone_destroy(void); > + > +/* subscriptions */ > +void rib_init_subscriptions(struct rib_head *rnh); > +void rib_destroy_subscriptions(struct rib_head *rnh); > + > +/* Nexhops */ > +void nhops_init(void); > +int nhops_init_rib(struct rib_head *rh); > +void nhops_destroy_rib(struct rib_head *rh); > +void nhop_ref_object(struct nhop_object *nh); > +int nhop_try_ref_object(struct nhop_object *nh); > +int nhop_ref_any(struct nhop_object *nh); > +void nhop_free_any(struct nhop_object *nh); > + > +void nhop_set_type(struct nhop_object *nh, enum nhop_type nh_type); > +void nhop_set_rtflags(struct nhop_object *nh, int rt_flags); > + > +int nhop_create_from_info(struct rib_head *rnh, struct rt_addrinfo > *info, > + struct nhop_object **nh_ret); > +int nhop_create_from_nhop(struct rib_head *rnh, const struct > nhop_object *nh_orig, > + struct rt_addrinfo *info, struct nhop_object **pnh_priv); > + > +void nhops_update_ifmtu(struct rib_head *rh, struct ifnet *ifp, > uint32_t mtu); +int nhops_dump_sysctl(struct rib_head *rh, struct > sysctl_req *w); + > +/* route */ > +struct rtentry *rt_unlinkrte(struct rib_head *rnh, struct > rt_addrinfo *info, > + int *perror); > =20 > #endif >=20 > Modified: head/sys/net/rtsock.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/rtsock.c Fri Aug 28 21:59:10 2020 > (r364940) +++ head/sys/net/rtsock.c Fri Aug 28 22:50:20 > 2020 (r364941) @@ -77,7 +77,6 @@ > #include > #endif > #include > -#include > =20 > #ifdef COMPAT_FREEBSD32 > #include >=20 > Modified: head/sys/netinet/in_fib.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netinet/in_fib.c Fri Aug 28 21:59:10 2020 > (r364940) +++ head/sys/netinet/in_fib.c Fri Aug 28 22:50:20 > 2020 (r364941) @@ -50,7 +50,6 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > -#include > #include > =20 > #ifdef RADIX_MPATH >=20 > Modified: head/sys/netinet/in_rmx.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netinet/in_rmx.c Fri Aug 28 21:59:10 2020 > (r364940) +++ head/sys/netinet/in_rmx.c Fri Aug 28 22:50:20 > 2020 (r364941) @@ -45,7 +45,6 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > -#include > #include > =20 > #include >=20 > Modified: head/sys/netinet6/in6_fib.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netinet6/in6_fib.c Fri Aug 28 21:59:10 > 2020 (r364940) +++ head/sys/netinet6/in6_fib.c Fri Aug > 28 22:50:20 2020 (r364941) @@ -51,7 +51,6 @@ > __FBSDID("$FreeBSD$"); #include > #include > #include > -#include > #include > =20 > #ifdef RADIX_MPATH >=20 > Modified: head/sys/netinet6/in6_rmx.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netinet6/in6_rmx.c Fri Aug 28 21:59:10 > 2020 (r364940) +++ head/sys/netinet6/in6_rmx.c Fri Aug > 28 22:50:20 2020 (r364941) @@ -84,7 +84,6 @@ > __FBSDID("$FreeBSD$"); #include > #include > #include > -#include > =20 > #include > #include > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to > "svn-src-head-unsubscribe@freebsd.org" This commit breaks "make buildkernel" on CURRENT for me on several CURRENT boxes: [...] x86 -> /usr/src/sys/x86/include --- route_ctl.o --- /usr/src/sys/net/route/route_ctl.c:315:30: error: variable 'netmask' is uninitialized when used here [-Werror,-Wuninitialized] rt_mpath_conflict(rnh, rt, netmask)) { ^~~~~~~ /usr/src/sys/net/route/route_ctl.c:297:33: note: initialize the variable 'netmask' to silence this warning --- modules-all --- --- all_subdir_acpi/acpi_video --- =3D=3D=3D> acpi/acpi_video (all) --- route_ctl.o --- struct sockaddr *ndst, *netmask; ^ =3D NULL --- modules-all --- --- all_subdir_amdgpio --- [...] Greetings, oh --Sig_/BkXhTkDbEWYS4IuN+9OceSu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQSy8IBxAPDkqVBaTJ44N1ZZPba5RwUCX0ojZQAKCRA4N1ZZPba5 R+ZeAQD5LeXZv0dgpNNRqQvknjeiyG6sxAzB5Ay2SIyDBq3C7wD+KDsFEY+YmPIf pDjjP+EX81EXnFIMRyEuY/5PsSTJ5w4= =RiTg -----END PGP SIGNATURE----- --Sig_/BkXhTkDbEWYS4IuN+9OceSu--