From owner-svn-src-head@freebsd.org  Fri Jul  6 13:22:45 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2DE81026B8B;
 Fri,  6 Jul 2018 13:22:45 +0000 (UTC)
 (envelope-from sbruno@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 42D7C80B3A;
 Fri,  6 Jul 2018 13:22:45 +0000 (UTC)
 (envelope-from sbruno@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 208681266;
 Fri,  6 Jul 2018 13:22:45 +0000 (UTC)
 (envelope-from sbruno@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w66DMjuX084524;
 Fri, 6 Jul 2018 13:22:45 GMT (envelope-from sbruno@FreeBSD.org)
Received: (from sbruno@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w66DMjRG084523;
 Fri, 6 Jul 2018 13:22:45 GMT (envelope-from sbruno@FreeBSD.org)
Message-Id: <201807061322.w66DMjRG084523@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: sbruno set sender to
 sbruno@FreeBSD.org using -f
From: Sean Bruno <sbruno@FreeBSD.org>
Date: Fri, 6 Jul 2018 13:22:44 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r336031 - head/usr.bin/top
X-SVN-Group: head
X-SVN-Commit-Author: sbruno
X-SVN-Commit-Paths: head/usr.bin/top
X-SVN-Commit-Revision: 336031
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 13:22:45 -0000

Author: sbruno
Date: Fri Jul  6 13:22:44 2018
New Revision: 336031
URL: https://svnweb.freebsd.org/changeset/base/336031

Log:
  r336028 changed next_msg to a char * from char [] of fixed size.  Change
  2nd argument of vsnprintf() to get the strlen of next_msg so that the
  appropriate size is used.
  
  Found with gcc.
  
  /usr.bin/top/display.c: In function 'new_message':
  /usr.bin/top/display.c:963:31: error:
  argument to 'sizeof' in 'vsnprintf' call is the same expression as the
  destination; did you mean to provide an explicit length?
  [-Werror=sizeof-pointer-memaccess]
       vsnprintf(next_msg, sizeof(next_msg), msgfmt, args);
  
  Reviewed by:	daichi

Modified:
  head/usr.bin/top/display.c

Modified: head/usr.bin/top/display.c
==============================================================================
--- head/usr.bin/top/display.c	Fri Jul  6 12:44:48 2018	(r336030)
+++ head/usr.bin/top/display.c	Fri Jul  6 13:22:44 2018	(r336031)
@@ -960,7 +960,7 @@ new_message(int type, const char *msgfmt, ...)
     va_start(args, msgfmt);
 
     /* first, format the message */
-    vsnprintf(next_msg, sizeof(next_msg), msgfmt, args);
+    vsnprintf(next_msg, strlen(next_msg), msgfmt, args);
 
     va_end(args);