From owner-svn-src-all@FreeBSD.ORG Sat Nov 10 08:36:03 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A36E72AD; Sat, 10 Nov 2012 08:36:03 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from fallbackmx10.syd.optusnet.com.au (fallbackmx10.syd.optusnet.com.au [211.29.132.251]) by mx1.freebsd.org (Postfix) with ESMTP id 3235D8FC08; Sat, 10 Nov 2012 08:36:02 +0000 (UTC) Received: from mail18.syd.optusnet.com.au (mail18.syd.optusnet.com.au [211.29.132.199]) by fallbackmx10.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id qAA8SCtD027977; Sat, 10 Nov 2012 19:28:12 +1100 Received: from c122-106-175-26.carlnfd1.nsw.optusnet.com.au (c122-106-175-26.carlnfd1.nsw.optusnet.com.au [122.106.175.26]) by mail18.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id qAA8S20Y025378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 10 Nov 2012 19:28:04 +1100 Date: Sat, 10 Nov 2012 19:28:02 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Xin LI Subject: Re: svn commit: r242842 - in head/sys: conf modules/mthca In-Reply-To: <201211100032.qAA0Wlvw090497@svn.freebsd.org> Message-ID: <20121110191905.H915@besplex.bde.org> References: <201211100032.qAA0Wlvw090497@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-Cloudmark-Score: 0 X-Optus-Cloudmark-Analysis: v=2.0 cv=fbv1UDsF c=1 sm=1 a=5sdN5XwoAGkA:10 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=L_8HYZ1iqUoA:10 a=SCQOxAknV-SESF-HZBkA:9 a=CjuIK1q_8ugA:10 a=bxQHXO5Py4tHmhUgaywp5w==:117 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2012 08:36:03 -0000 On Sat, 10 Nov 2012, Xin LI wrote: > Log: > Attempt toward a buildable universe by silenting a few warnings for OFED. > > Modified: > head/sys/conf/kern.pre.mk > head/sys/modules/mthca/Makefile Any chance of not adding style bugs in 1-line changes? > Modified: head/sys/conf/kern.pre.mk > ============================================================================== > --- head/sys/conf/kern.pre.mk Fri Nov 9 21:41:07 2012 (r242841) > +++ head/sys/conf/kern.pre.mk Sat Nov 10 00:32:47 2012 (r242842) > @@ -156,7 +156,7 @@ NORMAL_LINT= ${LINT} ${LINTFLAGS} ${CFLA > # Infiniband C flags. Correct include paths and omit errors that linux > # does not honor. > OFEDINCLUDES= -I$S/ofed/include/ > -OFEDNOERR= -Wno-cast-qual -Wno-pointer-arith -fms-extensions > +OFEDNOERR= -Wno-cast-qual -Wno-pointer-arith -fms-extensions -Wno-switch -Wno-sometimes-uninitialized -Wno-conversion -Wno-initializer-overrides > OFEDCFLAGS= ${CFLAGS:N-I*} ${OFEDINCLUDES} ${CFLAGS:M-I*} ${OFEDNOERR} > OFED_C_NOIMP= ${CC} -c -o ${.TARGET} ${OFEDCFLAGS} ${WERROR} ${PROF} > OFED_C= ${OFED_C_NOIMP} ${.IMPSRC} Please don't format source files or output for 150-column terminals, especially when 'fixing' code formatted for 80 columns. > Modified: head/sys/modules/mthca/Makefile > ============================================================================== > --- head/sys/modules/mthca/Makefile Fri Nov 9 21:41:07 2012 (r242841) > +++ head/sys/modules/mthca/Makefile Sat Nov 10 00:32:47 2012 (r242842) > @@ -28,4 +28,4 @@ opt_inet6.h: > > .include > > -CFLAGS+= -Wno-cast-qual -Wno-pointer-arith -fms-extensions > +CFLAGS+= -Wno-cast-qual -Wno-pointer-arith -fms-extensions -Wno-switch -Wno-sometimes-uninitialized -Wno-conversion -Wno-initializer-overrides This one also misformats the whitespace before the new set of options. Also, silencing warnings breaks them (unless they are bugs in clang). In normal development, it is just as easy to fix the bugs as to break the warnings, but there is a major compiler change lots of warnings are broken and then the bugs that they report tend to remain unfixed. The compiler should not be changed if it causes a single new warning. Bruce