From owner-freebsd-current Mon Nov 15 17:59:24 1999 Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 758) id 9C1A014DF9; Mon, 15 Nov 1999 17:59:23 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 8A3581CD43A; Mon, 15 Nov 1999 17:59:23 -0800 (PST) (envelope-from kris@hub.freebsd.org) Date: Mon, 15 Nov 1999 17:59:23 -0800 (PST) From: Kris Kennaway To: Pierre Beyssac Cc: freebsd-current@FreeBSD.ORG Subject: Re: egcs -O breaks ping.c:in_cksum() In-Reply-To: <19991116002921.A39215@fasterix.frmug.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 16 Nov 1999, Pierre Beyssac wrote: > > [in_cksum bugs] > > There's another bug in sbin/routed/rdisc.c:in_cksum() on odd packet > > sizes, albeit I'm not sure it's ever triggered (does routed ever > > generate odd-size packets?). > > I've checked, the answer is no: apparently, in_cksum() in routed/rdisc.c > is only called in two places, both with an even size. Can it hurt to pre-emptively fix it anyway in case some future change pulls the rug out from underneath? Kris ---- Cthulhu for President! For when you're tired of choosing the _lesser_ of two evils.. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message