From owner-svn-src-all@freebsd.org Thu Apr 16 23:31:40 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1F79A2CB351; Thu, 16 Apr 2020 23:31:40 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 493FqJ031bz4H1Z; Thu, 16 Apr 2020 23:31:40 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F120D18F02; Thu, 16 Apr 2020 23:31:39 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 03GNVdUj018937; Thu, 16 Apr 2020 23:31:39 GMT (envelope-from adrian@FreeBSD.org) Received: (from adrian@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 03GNVdou018936; Thu, 16 Apr 2020 23:31:39 GMT (envelope-from adrian@FreeBSD.org) Message-Id: <202004162331.03GNVdou018936@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: adrian set sender to adrian@FreeBSD.org using -f From: Adrian Chadd Date: Thu, 16 Apr 2020 23:31:39 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r360028 - head/bin/sh X-SVN-Group: head X-SVN-Commit-Author: adrian X-SVN-Commit-Paths: head/bin/sh X-SVN-Commit-Revision: 360028 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 23:31:40 -0000 Author: adrian Date: Thu Apr 16 23:31:39 2020 New Revision: 360028 URL: https://svnweb.freebsd.org/changeset/base/360028 Log: [sh] Fix a "may be unused" warning on mips-gcc mips-gcc for mips32 was complaining that c was potentially used before being set. Setting it to 0 before calling fdgetsc() looks like the right thing to do in this instance; there's an explicit check for c == 0 later on. Tested: mips-gcc mips32 build, running /bin/sh on mips32 Modified: head/bin/sh/miscbltin.c Modified: head/bin/sh/miscbltin.c ============================================================================== --- head/bin/sh/miscbltin.c Thu Apr 16 23:29:49 2020 (r360027) +++ head/bin/sh/miscbltin.c Thu Apr 16 23:31:39 2020 (r360028) @@ -245,6 +245,7 @@ readcmd(int argc __unused, char **argv __unused) lastnonifs = lastnonifsws = -1; fdctx_init(STDIN_FILENO, &fdctx); for (;;) { + c = 0; nread = fdgetc(&fdctx, &c); if (nread == -1) { if (errno == EINTR) {