From owner-cvs-all Sun Dec 3 4:19:11 2000 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id AA68D37B400; Sun, 3 Dec 2000 04:19:02 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id XAA22055; Sun, 3 Dec 2000 23:18:51 +1100 Date: Sun, 3 Dec 2000 23:19:33 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Jeroen Ruigrok van der Werven Cc: Will Andrews , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make arch.c compat.c cond.c dir.c hash.c job.c job.h list.h lst.h main.c make.c make.h parse.c sprite.h suff.c targ.c var.c src/usr.bin/make/lst.lib lstAppend.c lstConcat.c lstDatum.c lstDeQueue.c lstDestroy.c lstDupl.c ... In-Reply-To: <20001203103635.B42633@lucifer.bart.nl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 3 Dec 2000, Jeroen Ruigrok van der Werven wrote: > -On [20001203 09:15], Bruce Evans (bde@zeta.org.au) wrote: > >On Sat, 2 Dec 2000, Will Andrews wrote: > >> Log: > >> There's no reason to use fancy forms of NULL. Replace all instances > >> of NIL, NILLST, NILLGNODE, etc. with NULL. > > > >K&R support is one reason. > > In what way? foo(NULL) is an error if there is no prototype [in scope] for foo(). Non-erroneous K&R code would use foo((something *)0) or equivalent. The equivalent: #define NILSOMETHING ((something *)NULL) ... foo(NILSOMETHING); is probably preferable to casting 0 or NULL all over the place. Once NILSOMETHING is defined, using it everywhere is probably preferable to using it only in functiobn calls. This seems to be why the make(1) sources used it. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message