From owner-freebsd-bugs  Wed Sep 23 10:59:15 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id KAA11553
          for freebsd-bugs-outgoing; Wed, 23 Sep 1998 10:59:15 -0700 (PDT)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from dt053nb4.san.rr.com (dt053nb4.san.rr.com [204.210.34.180])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA11527;
          Wed, 23 Sep 1998 10:58:58 -0700 (PDT)
          (envelope-from Studded@dal.net)
Received: from dal.net (Studded@localhost [127.0.0.1])
	by dt053nb4.san.rr.com (8.8.8/8.8.8) with ESMTP id KAA06406;
	Wed, 23 Sep 1998 10:58:45 -0700 (PDT)
	(envelope-from Studded@dal.net)
Message-ID: <360936D5.9DAE1280@dal.net>
Date: Wed, 23 Sep 1998 10:58:45 -0700
From: Studded <Studded@dal.net>
Organization: Triborough Bridge & Tunnel Authority
X-Mailer: Mozilla 4.06 [en] (X11; I; FreeBSD 2.2.7-STABLE-0920 i386)
MIME-Version: 1.0
To: Drew Derbyshire <ahd@kew.com>
CC: freebsd-bugs@FreeBSD.ORG, freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: conf/8031: /etc/rc looks for /etc/sendmail.cf at startup
References: <199809231210.FAA18954@freefall.freebsd.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Drew Derbyshire wrote:

	This isn't directed towards Drew, but technically the RHS of the test
should be "XYES" instead of how it is now. The '=' conditional compares
strings, so the LHS is correct, and it should be the same on both sides.
There are numerous examples of this error. Although personally I would
prefer something that is a little more user friendly, like:

case "${sendmail_enable}" in
  YES | yes )
    echo -n ' sendmail'
    /usr/sbin/sendmail "${sendmail_flags}"
    ;;
esac

I'd be happy to submit a patch if it had a chance of being committed. :)
 
>  ! if [ "X${sendmail_enable}" = X"YES" ]; then
>         echo -n ' sendmail';    /usr/sbin/sendmail ${sendmail_flags}
>    fi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message