From owner-svn-src-all@FreeBSD.ORG Sun Jun 7 20:06:22 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 479FC9B7 for ; Sun, 7 Jun 2015 20:06:22 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm18-vm0.bullet.mail.bf1.yahoo.com (nm18-vm0.bullet.mail.bf1.yahoo.com [98.139.213.138]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA74E1671 for ; Sun, 7 Jun 2015 20:06:21 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1433707245; bh=Vj0KcGm4eTlu6xN7R1X7Xda20X7NaTaNjweS/zYx/5U=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=l29+ihJ4y367sQGeQQDz8FC6F+S28RS5lsDdiF+XENCqlJsgJNqTCUW8ecZOn7UZzY8+vQWePRgldlR0rVV+B2EXIsnQ42Yh8T8z+1xvwuYHGWvNIMHr0wx+6S1dscPYKB4wP9XilGi7l3ZXa/mmOKAbfcMEdHoNF20kqH3AnmzC/Y0o6eZ8ntMD0TBZHkt2L6XgFKcSNEyV8+Q2bMzFHmBrmOrSChrMziWvavtttSv1q17fHMCKGzuks/mPbOHXLv0kqjDHvZmmg83iz8mhAzypasEbryYbN3Y/ydB8tSri1cl35Vyz47IzIRKozinvIbccOycfni/MDri2F3T5gw== Received: from [66.196.81.171] by nm18.bullet.mail.bf1.yahoo.com with NNFMP; 07 Jun 2015 20:00:45 -0000 Received: from [68.142.230.75] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 07 Jun 2015 20:00:45 -0000 Received: from [127.0.0.1] by smtp232.mail.bf1.yahoo.com with NNFMP; 07 Jun 2015 20:00:45 -0000 X-Yahoo-Newman-Id: 606842.79970.bm@smtp232.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: hsnO4pAVM1nfCCeHSl3DS9ayEYwWf1ff_qdmrI9NCtI5gKv FC.n7.W6bMGAONuEELqQNzu7MSVdZdlnuh_tODQta01OcasaEPku5Ps5JHAB Wtf.SZ5PfchwSpLlTieJNazIRq7.YvZEIzbPZ4YVah2lYyJwEgd166nFzeig zjuS3tk6qboqOBe_kQSQxpFCpbviJiO4VWqPdcnZZaUA3e6oYVUeYdn9VTUN 76._XzKZHHKJWScCaBzsXl0OCaOVgBfCAFs4EcoQAGoB.bC6s3GGmmQMSctd Xww10RNloRixrhRvY.OxTm1m.vT66fRbC6CpujKhu6QvWzgLviw.qgy2sLJ6 gsH1vKJZ78LyXqnee5qmQTiM72sy_T6JJfxn2bLQCkmTC5sPNiYl8Ax8j4JH LZyxUXhTejkyhaLJflqkvAdtkiNR.XuThoFaVxXM9VtV_c2aFcejfoyR0coz eXTCHmGzo3O8VUaeA6LZc9zXWA3MiuoelrRrcnHV3unzgHOCRXQF7g1J2RsG 5Zr3v4esxE4l7f4aanJsRDFdtaBXV.GAZ X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <5574A2F9.8080404@FreeBSD.org> Date: Sun, 07 Jun 2015 15:00:57 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Marcelo Araujo CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r284116 - head/sys/boot/ficl References: <201506071420.t57EKnio083109@svn.freebsd.org> <5F622B98-A1AE-41FB-8E4A-E767DB928689@gmail.com> In-Reply-To: <5F622B98-A1AE-41FB-8E4A-E767DB928689@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jun 2015 20:06:22 -0000 On 06/07/15 12:06, Garrett Cooper wrote: >> On Jun 7, 2015, at 07:20, Marcelo Araujo wrote: >> >> Author: araujo (ports committer) >> Date: Sun Jun 7 14:20:48 2015 >> New Revision: 284116 >> URL: https://svnweb.freebsd.org/changeset/base/284116 >> >> Log: >> Include header libi386.h to silence the clang warning of implicit declaration >> of functions biospci_*. >> >> Differential Revision: D2668 >> Reviewed by: rodrigc >> >> Modified: >> head/sys/boot/ficl/loader.c >> >> Modified: head/sys/boot/ficl/loader.c >> ============================================================================== >> --- head/sys/boot/ficl/loader.c Sun Jun 7 13:59:02 2015 (r284115) >> +++ head/sys/boot/ficl/loader.c Sun Jun 7 14:20:48 2015 (r284116) >> @@ -46,6 +46,7 @@ >> #include "bootstrap.h" >> #include >> #include "ficl.h" >> +#include "../i386/libi386/libi386.h" > Hi Marcelo, > > This commit's explicitly polluting the ficl interpreter with code from x86 on all platforms. Seems like the code should be refactored to not explicitly include this symbol, then #include this header there. That's the real bug.. +1 Let's revert and let the ficl GSoC take care of it. Pedro.