From nobody Thu Dec 11 20:43:36 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dS4LK5Dndz6KLNH for ; Thu, 11 Dec 2025 20:43:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dS4LK0pSjz3Zt7 for ; Thu, 11 Dec 2025 20:43:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765485817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iqppPUw0x7PL9IiaTqvO+dlWqWDicYXABDtqNrBW+8g=; b=pfWvQG1NQiM+QEfOZ0Azm095Ur9eM83ZtjpsE6/eoLUTpEeTmsVyrptux8x9O9Uoqlsyck jEbVcqX8hUSUOWewU+a/jphZ0RvrxkAQ4Y6jOaIZoPXu2UUewr/mgI7dZim00uPOTy6P73 bkulcn8w1dQjcMHApTcD7GePWjEOlPAeQRsEgSQQElfBqphDU3o0Hf+ludeyAUEJdLfJlf zx2BArZ6LjH6ba0jRK6sxfQm6g8BWqlWfswj5G+WaHxabN+p8fgtJF2PEId3OImQktpc0z XmO/+Pa5KHqQeve2ZborBMc4OS0MTLibnB4U0YYsictvn5PzfBlBUlN2JJ1D+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765485817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iqppPUw0x7PL9IiaTqvO+dlWqWDicYXABDtqNrBW+8g=; b=u1a8G7QOmj4XhDysn0yqDacsscli7pIbXIu3atYVD8ibumN3ayDv9bqGkf/+nlC8l3AgmA 0PMqZcRWaKEGwvT2oZvuVNpEM7Zv/GtrUMWrInWhQXLQbEb4MsJPZpn/wGZzJeHEgKAiI6 Z7OYp7qRQAmuThBmdAtoxYesx+nspzIiKc/8nSK8uxBTYlrs5tbr99/FlkpOshEggUblzA J2x8KUQm1kweXGU4REkgjtx2nKXUlehOuQVYsj44BhfEGe50UfTRUTU61jMq/rX0igqb6D uaPoKXOYbJV6jItg4y0CRDWBEhD6rLGvx+beOKfKxEmY12N/EkZD0sTMWYkj9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765485817; a=rsa-sha256; cv=none; b=Vr2ikxYBXrZnyrgoa5A3Z0MaxisOxglwu7vdcGNL4EeJWvJy0dcXLXFw4nxaPyCBruYsiT ElOoQU7Bgpl7m7faJG7R+MoaHn9An7uS9LEu3IlIcKVmQsCpnC60DzNqItzSd3FIRTAR5i GDGTHbVXmOPUSplIvUnWv8Q0I46mRSO0J2jNazqJtermYnUfUiMwMBRiZAw0p7bJII6sxb GGOiN7iiBVLMzMkPPmzD6Rp00U2gdP1FWOH3hBxISKHvizZ3wv+PFMXGpmEstXyvNNR6Ko XHC2JZ0782125cJko6vExFnCfwGc9q2Zibr/bmdJC831Edb4OJgC98/pkBXU0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dS4LJ5ZWpznF6 for ; Thu, 11 Dec 2025 20:43:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30eaf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 11 Dec 2025 20:43:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: ca69366da969 - stable/15 - e1000: Don't enable ASPM L1 without L0s List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ca69366da969ad95630d2db9458849ddef226229 Auto-Submitted: auto-generated Date: Thu, 11 Dec 2025 20:43:36 +0000 Message-Id: <693b2cf8.30eaf.6b59ae41@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=ca69366da969ad95630d2db9458849ddef226229 commit ca69366da969ad95630d2db9458849ddef226229 Author: Kevin Bowling AuthorDate: 2025-11-21 05:47:03 +0000 Commit: Kevin Bowling CommitDate: 2025-12-11 20:43:26 +0000 e1000: Don't enable ASPM L1 without L0s Reporter noted packet loss with 82583. NVM is down level. The errata docs mention disabling this, which should be the firmware default, so I am not sure why we were enabling this bit. Linux and OpenBSD have the same issue, while NetBSD got it right. Reported by: Codin Tested by: Codin (cherry picked from commit 2ead091715dee327b3e00bc9840e1a95827b8e82) --- sys/dev/e1000/e1000_82571.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/e1000/e1000_82571.c b/sys/dev/e1000/e1000_82571.c index e8970adf996f..650169663f56 100644 --- a/sys/dev/e1000/e1000_82571.c +++ b/sys/dev/e1000/e1000_82571.c @@ -1118,7 +1118,8 @@ static s32 e1000_init_hw_82571(struct e1000_hw *hw) case e1000_82574: case e1000_82583: reg_data = E1000_READ_REG(hw, E1000_GCR); - reg_data |= E1000_GCR_L1_ACT_WITHOUT_L0S_RX; + /* 82574 Errata 25, 82583 Errata 12 */ + reg_data &= ~E1000_GCR_L1_ACT_WITHOUT_L0S_RX; E1000_WRITE_REG(hw, E1000_GCR, reg_data); break; default: