From owner-svn-src-head@freebsd.org Fri Nov 8 16:27:36 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B9FC81B6EE1; Fri, 8 Nov 2019 16:27:36 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 478lzq6WhFz4Z0F; Fri, 8 Nov 2019 16:27:35 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-qv1-xf42.google.com with SMTP id x14so2435645qvu.0; Fri, 08 Nov 2019 08:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tD2yvSSWSBFNr73tUkwjt9YSORzRbKnUxzi18dj7coQ=; b=T7HNvI4X53Lx0qoufhDwJDGNJJVKxA7c2KWUe9IXRXQbPsVwo5jv1IJhXyObQvwrYF H8umiTp6xI81C3VYz5s4djQAqRXtVS+1mn+TawCDvHuuaXcAGsjIaUu5gQ1QvQvLnpnz 1y7uswk2HvZlZXmxe3Dmn5y7wvxazf0drS2sdZlsQ2MrPtMJzNFCNKgfpoMC2llf6YO9 jk17oJB1tIRTWvbspsigiAaKn0uiDa7hP+gzZEdBJsX/g2N9Ogm0xhTOBvPBnSLQA8Tv WunAGNTim/Qm7Ufquzq+EatoeJYRYOe9J5F/BIqLbIHW0+QIvF6k/+mT7km97GrnMou4 UY/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=tD2yvSSWSBFNr73tUkwjt9YSORzRbKnUxzi18dj7coQ=; b=HRmuyGtGP9uRERTZZYmAPS9pXFoUzvKG4MvrI39dTCDdFVAqikdFGWGZvbWDBAPGor ged3ZxjY9bqI5pIBBffYlNjHtQ6xmnAdQjCLutb+kokCs0flATjDQb/Ol9JcW3TtWJKq xnGMUa+MLvPl80Z1LvpyyDNrYuyKBu5epHIv8SHCcAu/YFOj2CtI7mr1sFQ+EOLHnLS9 J8poXTm39MAXQXmPFKV8eI8GGIg88pfbqaCSr58nPUkrsHmK6gSu/A6C2IHr28liZlRn e3lh8M1R41F2DjN0pxGH23epwROyislA/zYXWu5QbLFxq+IJOARDJEVuYs/kXvREsHHE NA/w== X-Gm-Message-State: APjAAAW2DLciSL+p2iEpXVJXNBrpgdffD96S7BGyO3IFAZi5Um/mupEP qMx+ydB+CDIr9bcWRIi0kpMqaV// X-Google-Smtp-Source: APXvYqzuGEF7gvfB9LH4d1JjXmEvGUNElbednLnpJpkzh9pt+mmUD37/68nS2jr4DFEfRgu/12JH3g== X-Received: by 2002:ad4:55c7:: with SMTP id bt7mr10174576qvb.29.1573230454270; Fri, 08 Nov 2019 08:27:34 -0800 (PST) Received: from mbp.home ([2804:f1c:800:fc00:351a:3009:3672:3590]) by smtp.gmail.com with ESMTPSA id t27sm2793257qkm.19.2019.11.08.08.27.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2019 08:27:33 -0800 (PST) Sender: Renato Botelho Subject: Re: svn commit: r354149 - head/sys/net To: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201910291736.x9THa6Gd018030@repo.freebsd.org> From: Renato Botelho Autocrypt: addr=garga@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFn4ZqUBCACxJRWi57JkmsCrSU0gZd/CwB+B90OTUeXmF63lDPETOQ+pBA4+vJgzjW1C pv7rR25wxvESJKphxZJOOk9AXTXsg5QrhdP3+KQG/zNcKd2ukbt3ezkhdMx8q81wn4wY2oTl WXdGIVdDKvC8sCp1fc6pPKJin71/skb9wg6ThtlRFlv9en4f8QSVmRuzRKQ6VjCbl+yIpiye /I5BQ4I99uouPzPhzf9ya3cvp4xbiw5wSo1F3nLsThBT2osYy/nRNz2ciuCYyyX87dGhio0T 8Pxl37eBbGQvCGwPQBApCcfoiZBN/5F65Tt4p72gIqT+AYuqq5G7Bhj+fGTC7q0QotL/ABEB AAG0LFJlbmF0byBCb3RlbGhvIChGcmVlQlNEKSA8Z2FyZ2FARnJlZUJTRC5vcmc+iQFXBBMB CgBBAhsDBQkFo5qABQsJCAcDBRUKCQgLBRYDAgEAAh4BAheAFiEExxiLNMqsn7yXmTy7W54E w5ZrhhoFAln4aeUCGQEACgkQW54Ew5ZrhhpTIwf+OS+Gv/ITOy7+8D+8SKXNmkfczsTO+Uqz 6SraXcq32j1C4QcRQCwGPhVJJgKnFSvPm3kbNPFXaQh1zD+mTQ4r/Loc78Rz+fZljYcgNx7n aQKhd9pdpXaELOe+Y10jvGUrT0SE06Y10BP/NmQaLplt9qG8VgLAAB9ZcsuZ9pzbBbQjd9In OK5VcXQzHT/EBBQ1rHsl1Aq8TYdmjbKl+HKc1c8dJ5OfXrgnTIUwQdN1rauXbmH/YW/CKN7z zF59v/sPBTaWfFl2CS/BORhWhe1PBudrVZWFT0oJGNuG6k8dlnssoL/0ojFaN5w5xm8mvMAf uAuixGf4bK6C7hcE34D/ULkBDQRZ+GalAQgApiTibUM0OpeCcxf5YUep4F4y853ClU4TMqZO +ho38sz0GdshQWuBEBqahOtxapHUMtlmC+wJNCBAav5JYjHHrXXE9pgRm5EgVssDpMvplLB4 5CFdx5jBu02Bt9Wp5bD21TPH3rsYJUB3rYmxWfVmdRhNBERrCJu49OIsBSKAlIinx8altYrh Z7bO2C1hKOG6QHWRr4ml4HTD/gZ6TTfsrR+sktBNv/5ZRkcJNDVM+eOGagXkEUOVFe9KXynD 3KcZBbBKpwoaW5GK8OglKJt8ggUfc78CG1xk4b5nL8QCk0CBrC6VPPOYvXTpYSTHmx1QkElm 1iNu1Tc5ccvcyAwTswARAQABiQE8BBgBCgAmFiEExxiLNMqsn7yXmTy7W54Ew5ZrhhoFAln4 ZqUCGwwFCQWjmoAACgkQW54Ew5ZrhhoH3wf+KuIeDyvIJOui+0C5FD5r44Bwkj/SAUVUerfp 0qtRktc+BZoSifPs3Rqjh/PpwRvLTuJnSsiqWLz8NCTThogRzVqEcQHqZR3vOjtYM60sjYJ+ BGQl/bjm1C/YtWEEmKs7mJc+02U8qJA4rbNKSRRRoz6XngnuN6YC0fkeD7c7rxRhOg6OWasZ JinB9+dO1IH7eZ5c97v518qSaLRp0T7I+FpEGOp7tTFHaepZWEnuojr5D6jI1MOEywy0EWJu 3m0TYlh935I8o7gLABqoHEmUeW7JK7r91SZaFnr8zQ6XOAxkPh50uFMTNtNZTnM7k1pRv5Ov fms0VzARITYzTwmpDQ== Message-ID: <781d285f-0b6d-45f1-f4b4-4bab60b789ae@FreeBSD.org> Date: Fri, 8 Nov 2019 13:27:30 -0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <201910291736.x9THa6Gd018030@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 478lzq6WhFz4Z0F X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=T7HNvI4X; dmarc=none; spf=pass (mx1.freebsd.org: domain of gargabsd@gmail.com designates 2607:f8b0:4864:20::f42 as permitted sender) smtp.mailfrom=gargabsd@gmail.com X-Spamd-Result: default: False [-3.08 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.88)[ipnet: 2607:f8b0::/32(-2.34), asn: 15169(-2.01), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FORGED_SENDER(0.30)[garga@FreeBSD.org,gargabsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[garga@FreeBSD.org,gargabsd@gmail.com] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 16:27:36 -0000 On 29/10/19 14:36, Gleb Smirnoff wrote: > Author: glebius > Date: Tue Oct 29 17:36:06 2019 > New Revision: 354149 > URL: https://svnweb.freebsd.org/changeset/base/354149 > > Log: > There is a long standing problem with multicast programming for NICs > and IPv6. With IPv6 we may call if_addmulti() in context of processing > of an incoming packet. Usually this is interrupt context. While most > of the NIC drivers are able to reprogram multicast filters without > sleeping, some of them can't. An example is e1000 family of drivers. > With iflib conversion the problem was somewhat hidden. Iflib processes > packets in private taskqueue, so going to sleep doesn't trigger an > assertion. However, the sleep would block operation of the driver and > following incoming packets would fill the ring and eventually would > start being dropped. Enabling epoch for the full time of a packet > processing again started to trigger assertions for e1000. > > Fix this problem once and for all using a general taskqueue to call > if_ioctl() method in all cases when if_addmulti() is called in a > non sleeping context. Note that nobody cares about returned value. > > Reviewed by: hselasky, kib > Differential Revision: https://reviews.freebsd.org/D22154 Hi Gleb, I upgraded my laptop running 13-CURRENT from r354133 to r354437 and it crashed during boot as you can see in the pictures [1]. It seems like it crashed while it was configuring network. After bisect I managed to boot fine with r354148 and reproduce the crash with this revision applied. Here is the relevant portion of my /etc/rc.conf: # Lagg ifconfig_em0="up" wlans_iwn0="wlan0" ifconfig_wlan0="WPA" create_args_wlan0="wlanaddr 3c:97:0e:48:3f:f8 up" cloned_interfaces="lagg0" ifconfig_lagg0="up laggproto failover laggport em0 laggport wlan0 DHCP" ifconfig_lagg0_ipv6="inet6 accept_rtadv" rtsold_enable="YES" [1] https://imgur.com/a/lBtq3FW -- Renato Botelho