From owner-cvs-all  Sun Jan  5 13:22:21 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 24C7837B401; Sun,  5 Jan 2003 13:22:20 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CB08543EB2; Sun,  5 Jan 2003 13:22:18 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id IAA31478;
	Mon, 6 Jan 2003 08:22:12 +1100
Date: Mon, 6 Jan 2003 08:22:33 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Nate Lawson <nate@root.org>
Cc: Jake Burkholder <jake@FreeBSD.org>, <cvs-all@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/sab sab.c
In-Reply-To: <Pine.BSF.4.21.0301051210580.7893-100000@root.org>
Message-ID: <20030106075621.M616-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 5 Jan 2003, Nate Lawson wrote:

> On Sat, 4 Jan 2003, Jake Burkholder wrote:
> >   Modified files:
> >     sys/dev/sab          sab.c
> >   Log:
> >   Sync with zs.
> >   - Fix some bogosity with mixing unit numbers and channels, which would only
> >     work for one instance of the device.
> >   - Use a simpler scheme for input and output queueing.
> >   - Use db_alt_break.
> >
> >   Revision  Changes    Path
> >   1.8       +178 -238  src/sys/dev/sab/sab.c
>
> I've always wondered if you were supposed to deliver the char before
> calling breakpoint().  Looks like you do this but it seemed like sio
> didn't.  What's the desired behavior?

The escape sequence for the breakpoint shouldn't be delivered at all.
sio seems to get this right for the final character in the sequence
(using "goto cont;") but not for the previous characters (it sets the
state variables for them but falls through to handle them normally).
If the final character is delivered, then whether it is delivered
before or after calling breakpoint() doesn't matter much.  Only the
internals of the interrupt handler and the state machine could
normally tell the difference.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message